ColumnCacheTest fails in findOrCreate()

Hi Anthony,

the tests fail right now in ColumnCacheTest at line 126
(findOrCreateTest) if the Driver supportsLocking().

I guess this is why you didn't catch it with Hsql.

To make it pass, I have changed the code in
SRecordInstance.setOptimistic(boolean) to this:

public void setOptimistic(boolean optimistic) {
	    if (!isOptimistic && isDirty() && !isNewRow() && optimistic) // new
will always be dirty, but as insert  should be ok.
				throw new SException.Error("Cannot make dirty record optimisitic " +
this);
        isOptimistic = optimistic;        
    }

So I added the '&& optimistic', as calling setOptimistic(false) was
failing.

Does it seem right to you ? (if so I'll commit)

Franck



------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/SimpleORM/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/SimpleORM/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[email protected] 
    mailto:[email protected]

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/