Re: [patch] add CLOB datatype
Franck Routier <[email protected]> Thu, 26 Apr 2012 14:55:31 +0200
| Newsgroups | gmane.comp.java.orm.simpleorm |
|---|---|
| Message-ID | <[email protected]> |
--------------000201020404060506070708
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Ok. So I'll fix this.
What I have done is :
1) allow user to choose a maxAutoRetrieveSize, to (eventually) avoid
getting all content when building the SRecordInstance
2) tweak Prostgresql, CachéDB and Mysql driver (to get the right sql
type, eg TEXT or LONGVARCHAR)
3) add a test in DataTypeTest
Notice :
1) Postgresql does not really support Clobs.
This would map to TEXT fields, but the streaming part is not
implemented, and the whole text will be in the resultset anyway.
2) I was not able to find a way to allow interaction with the Clob object.
Maybe with another SFieldXXXX that would have an internal type
java.sql.Clob (but then you could only interact while within the
transaction as I understand it).
Anyway, it's probably not very useful for now.
I have added a test case, but I have no Oracle database to test it now.
Anyone willing to test is welcome.
Regards,
Franck
Le 26/04/2012 11:41, Noel Grandin a écrit :
> You know, you are right, that loop does look dodgy.
> To be honest, my code only briefly used CLOB's and then I moved onto
> something else, so that code is no longer in use here.
>
> On 2012-04-24 12:18, Franck Routier wrote:
>> Ok.
>> But, then maybe we should give the user (I mean the developper using
>> Simpleorm) an access to the Clob object, instead of fetching its
>> value on queryFieldValue ?
>> And maybe add a custom method to SFieldClob that would effectively
>> fetch the value, but not on queryFieldValue ?
>>
>>
>> Another point is, did this code work ? I'm asking because the break
>> condition in queryFieldValue seems erroneous, as reader.read(buf)
>> will return -1 on end of file, not 0. ?
>>
>> Franck
>>
>> Le 24/04/2012 11:12, Noel Grandin a écrit :
>>> No good reason, just that it would be a little surprising
>>> performance wise - could trigger a very long fetch from the server
>>> that is likely to be uncached.
>>>
>>> But I don't have a principled objection to it.
>>>
>>> On 2012-04-24 09:12, Franck Routier wrote:
>>>>
>>>> Hi Noël and Anthony,
>>>>
>>>> I've been looking at your code, and I was wondering why Clobs
>>>> wouldn't be comparable... What is the reason behind that ?
>>>> Typically, Postgresql type for Clobs (TEXT) would just compare
>>>> fine, as well as java representation of a Clob (a String).
>>>> Is there any Oracle specificity around that, or simply a size
>>>> problem ??
>>>>
>>>> Thanks,
>>>> Franck
>>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>> Disclaimer: http://www.peralex.com/disclaimer.html
>>>
>>
>
>
>
> ------------------------------------------------------------------------
> Disclaimer: http://www.peralex.com/disclaimer.html
>
--------------000201020404060506070708
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
<head>
<style type="text/css">
<!--
/* start of attachment style */
.ygrp-photo-title{
clear: both;
font-size: smaller;
height: 15px;
overflow: hidden;
text-align: center;
width: 75px;
}
div.ygrp-photo{
background-position: center;
background-repeat: no-repeat;
background-color: white;
border: 1px solid black;
height: 62px;
width: 62px;
}
div.photo-title
a,
div.photo-title a:active,
div.photo-title a:hover,
div.photo-title a:visited {
text-decoration: none;
}
div.attach-table div.attach-row {
clear: both;
}
div.attach-table div.attach-row div {
float: left;
/* margin: 2px;*/
}
p {
clear: both;
padding: 15px 0 3px 0;
overflow: hidden;
}
div.ygrp-file {
width: 30px;
valign: middle;
}
div.attach-table div.attach-row div div a {
text-decoration: none;
}
div.attach-table div.attach-row div div span {
font-weight: normal;
}
div.ygrp-file-title {
font-weight: bold;
}
/* end of attachment style */
-->
</style>
</head>
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Ok. So I'll fix this.<br>
<br>
What I have done is :<br>
1) allow user to choose a maxAutoRetrieveSize, to (eventually) avoid
getting all content when building the SRecordInstance<br>
2) tweak Prostgresql, CachéDB and Mysql driver (to get the right
sql type, eg TEXT or LONGVARCHAR)<br>
3) add a test in DataTypeTest<br>
<br>
Notice :<br>
1) Postgresql does not really support Clobs.<br>
This would map to TEXT fields, but the streaming part is not
implemented, and the whole text will be in the resultset anyway.<br>
2) I was not able to find a way to allow interaction with the Clob
object.<br>
Maybe with another SFieldXXXX that would have an internal type
java.sql.Clob (but then you could only interact while within the
transaction as I understand it).<br>
Anyway, it's probably not very useful for now.<br>
<br>
I have added a test case, but I have no Oracle database to test it
now. Anyone willing to test is welcome.<br>
<br>
Regards,<br>
Franck<br>
<br>
Le 26/04/2012 11:41, Noel Grandin a écrit :
<blockquote cite="mid:[email protected]" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
You know, you are right, that loop does look dodgy. <br>
To be honest, my code only briefly used CLOB's and then I moved
onto something else, so that code is no longer in use here.<br>
<br>
On 2012-04-24 12:18, Franck Routier wrote:
<blockquote cite="mid:[email protected]" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Ok. <br>
But, then maybe we should give the user (I mean the developper
using Simpleorm) an access to the Clob object, instead of
fetching its value on queryFieldValue ?<br>
And maybe add a custom method to SFieldClob that would
effectively fetch the value, but not on queryFieldValue ?<br>
<br>
<br>
Another point is, did this code work ? I'm asking because the
break condition in queryFieldValue seems erroneous, as
reader.read(buf) will return -1 on end of file, not 0. ?<br>
<br>
Franck <br>
<br>
Le 24/04/2012 11:12, Noel Grandin a écrit :
<blockquote cite="mid:[email protected]" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
No good reason, just that it would be a little surprising
performance wise - could trigger a very long fetch from the
server that is likely to be uncached.<br>
<br>
But I don't have a principled objection to it.<br>
<br>
On 2012-04-24 09:12, Franck Routier wrote:
<blockquote cite="mid:[email protected]" type="cite">
<span style="display:none"> </span>
<div id="ygrp-text">
<p> Hi Noël and Anthony,<br>
<br>
I've been looking at your code, and I was wondering
why Clobs wouldn't be comparable... What is the
reason behind that ?<br>
Typically, Postgresql type for Clobs (TEXT) would
just compare fine, as well as java representation of
a Clob (a String).<br>
Is there any Oracle specificity around that, or
simply a size problem ??<br>
<br>
Thanks,<br>
Franck<br>
<br>
</p>
</div>
</div>
</div>
<!-- end group email --> </blockquote>
<br>
<br>
<br>
<hr><font color="808080" size="-2">Disclaimer: <a
moz-do-not-send="true"
href="http://www.peralex.com/disclaimer.html">http://www.peralex.com/disclaimer.html</a><br>
<br>
</font></blockquote>
<br>
</blockquote>
<br>
<br>
<br>
<hr><font color="808080" size="-2">Disclaimer: <a
moz-do-not-send="true"
href="http://www.peralex.com/disclaimer.html">http://www.peralex.com/disclaimer.html</a><br>
<br>
</font></blockquote>
<br>
<!-- |**|begin egp html banner|**| -->
<br>
<br>
<!-- |**|end egp html banner|**| -->
<div width="1" style="color: white; clear: both;"/>__._,_.___</div>
<!-- Start Recommendations -->
<!-- End Recommendations -->
<!-- |**|begin egp html banner|**| -->
<img src="http://geo.yahoo.com/serv?s=97476590/grpId=7360226/grpspId=1705006905/msgId=2056/stime=1335444972" width="1" height="1"> <br>
<!-- |**|end egp html banner|**| -->
<!-- |**|begin egp html banner|**| -->
<br>
<div style="font-family: verdana; font-size: 77%; border-top: 1px solid #666; padding: 5px 0;" >
Your email settings: Individual Email|Traditional <br>
<a href="http://groups.yahoo.com/group/SimpleORM/join;_ylc=X3oDMTJmbzJnZjRpBF9TAzk3NDc2NTkwBGdycElkAzczNjAyMjYEZ3Jwc3BJZAMxNzA1MDA2OTA1BHNlYwNmdHIEc2xrA3N0bmdzBHN0aW1lAzEzMzU0NDQ5NzI-">Change settings via the Web</a> (Yahoo! ID required) <br>
Change settings via email: <a href="mailto:[email protected]?subject=Email Delivery: Digest">Switch delivery to Daily Digest</a> | <a href = "mailto:[email protected]?subject=Change Delivery Format: Fully Featured">Switch to Fully Featured</a> <br>
<a href="http://groups.yahoo.com/group/SimpleORM;_ylc=X3oDMTJkNWwzbzltBF9TAzk3NDc2NTkwBGdycElkAzczNjAyMjYEZ3Jwc3BJZAMxNzA1MDA2OTA1BHNlYwNmdHIEc2xrA2hwZgRzdGltZQMxMzM1NDQ0OTcy">
Visit Your Group
</a> |
<a href="http://docs.yahoo.com/info/terms/">
Yahoo! Groups Terms of Use
</a> |
<a href="mailto:[email protected]?subject=Unsubscribe">
Unsubscribe
</a>
<br>
</div>
<br>
<!-- |**|end egp html banner|**| -->
<div style="color: white; clear: both;"/>__,_._,___</div>
</body>
</html>
--------------000201020404060506070708--