Re: [PATCH] fix for bug in SRecordGeneric

Franck Routier <[email protected]> Mon, 04 Jun 2012 13:37:11 +0200
Newsgroups gmane.comp.java.orm.simpleorm
Message-ID <[email protected]>
--------------070608090500060607090108
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Oh... I see. I apply the patch and commit ASAP.

Thanks again.

Franck


Le 04/06/2012 12:30, Noel Grandin a écrit :
>
> No, the problem is that some tools are using
>    new Boolean(true)
> which results in the method returning false.
>
> On 2012-06-04 11:36, Franck Routier wrote:
>
>> Thanks Noel for the patch.
>> Do you have more information about the problem this corrects ? I 
>> guess it must a NPE when the map contains a null value for the field, 
>> but I would just like to check it is not hidding another bug.
>>
>> Franck
>>
>>
>>
>> Le 04/06/2012 11:23, Noel Grandin a écrit :
>>>
>>> Hi
>>>
>>> There is a bug in SRecordGeneric.getBoolean that manifests in some odd
>>> situations.
>>>
>>> Patch attached.
>>>
>>> Regards, Noel Grandin
>>>
>>> Disclaimer: http://www.peralex.com/disclaimer.html
>>>
>>
>
>
>
> ------------------------------------------------------------------------
> Disclaimer: http://www.peralex.com/disclaimer.html
>
> 


--------------070608090500060607090108
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit





<head>

<style type="text/css">
<!--

/* start of attachment style */
       .ygrp-photo-title{
         clear: both;
         font-size: smaller;
         height: 15px;
         overflow: hidden;
         text-align: center;
         width: 75px;
       }
       div.ygrp-photo{
         background-position: center;
         background-repeat: no-repeat;
         background-color: white;
         border: 1px solid black;
         height: 62px;
         width: 62px;
       }

       div.photo-title 
         a,
         div.photo-title a:active,
         div.photo-title a:hover,
         div.photo-title a:visited {
           text-decoration: none; 
       }

       div.attach-table div.attach-row {
         clear: both;
       }

       div.attach-table div.attach-row div {
         float: left;
         /* margin: 2px;*/
       }

       p {
         clear: both;
         padding: 15px 0 3px 0;
	 overflow: hidden;
       }

       div.ygrp-file {
         width: 30px;
         valign: middle;
       }
       div.attach-table div.attach-row div div a {
         text-decoration: none;
       }

       div.attach-table div.attach-row div div span {
         font-weight: normal;
       }

       div.ygrp-file-title {
         font-weight: bold;
       }
 /* end of attachment style */
        -->
        </style>
        </head>
<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">





    Oh... I see. I apply the patch and commit ASAP.<br>
    <br>
    Thanks again.<br>
    <br>
    Franck<br>
    <br>
    <br>
    Le 04/06/2012 12:30, Noel Grandin a &eacute;crit&nbsp;:
    <blockquote cite="mid:[email protected]" type="cite">
      <span style="display:none">&nbsp;</span>
      
          <div id="ygrp-text">
            <p> No, the problem is that some tools are using <br>
              &nbsp;&nbsp; new Boolean(true)<br>
              which results in the method returning false.<br>
              <br>
              On 2012-06-04 11:36, Franck Routier wrote: </p>
            <blockquote cite="mid:[email protected]"
              type="cite"> Thanks Noel for the patch.<br>
              Do you have more information about the problem this
              corrects ? I guess it must a NPE when the map contains a
              null value for the field, but I would just like to check
              it is not hidding another bug.<br>
              <br>
              Franck<br>
              <br>
              <br>
              <br>
              Le 04/06/2012 11:23, Noel Grandin a &eacute;crit&nbsp;:
              <blockquote cite="mid:[email protected]"
                type="cite"> <span>&nbsp;</span>
                <div id="ygrp-text">
                  <p>Hi<br>
                    <br>
                    There is a bug in SRecordGeneric.getBoolean that
                    manifests in some odd <br>
                    situations.<br>
                    <br>
                    Patch attached.<br>
                    <br>
                    Regards, Noel Grandin<br>
                    <br>
                    Disclaimer: <a moz-do-not-send="true" moz="true"
                      href="http://www.peralex.com/disclaimer.html">http://www.peralex.com/disclaimer.html</a><br>
                    <br>
                  </p>
                </div>
                <!-- end group email --> </blockquote>
              <br>
            </blockquote>
            <br>
            <br>
            <br>
            <hr><font size="-2" color="808080">Disclaimer: <a
                moz-do-not-send="true"
                href="http://www.peralex.com/disclaimer.html">http://www.peralex.com/disclaimer.html</a><br>
              <br>
            </font> </div>
          
      
      <!-- end group email -->
    </blockquote>
    <br>
  



<!-- |**|begin egp html banner|**| -->

<br>

    
    
<br>

<!-- |**|end egp html banner|**| -->


<div width="1" style="color: white; clear: both;"/>__._,_.___</div>

<!-- Start Recommendations -->
<!-- End Recommendations -->



<!-- |**|begin egp html banner|**| -->

  <img src="http://geo.yahoo.com/serv?s=97476590/grpId=7360226/grpspId=1705006905/msgId=2062/stime=1338809867" width="1" height="1"> <br>

<!-- |**|end egp html banner|**| -->

    
<!-- |**|begin egp html banner|**| -->

<br>
      <div style="font-family: verdana; font-size: 77%; border-top: 1px solid #666; padding: 5px 0;" >
      Your email settings: Individual Email|Traditional <br>
      <a href="http://groups.yahoo.com/group/SimpleORM/join;_ylc=X3oDMTJmZ2V2NmVoBF9TAzk3NDc2NTkwBGdycElkAzczNjAyMjYEZ3Jwc3BJZAMxNzA1MDA2OTA1BHNlYwNmdHIEc2xrA3N0bmdzBHN0aW1lAzEzMzg4MDk4Njc-">Change settings via the Web</a> (Yahoo! ID required) <br>
      Change settings via email: <a href="mailto:[email protected]?subject=Email Delivery: Digest">Switch delivery to Daily Digest</a> | <a href = "mailto:[email protected]?subject=Change Delivery Format: Fully Featured">Switch to Fully Featured</a> <br>
           <a href="http://groups.yahoo.com/group/SimpleORM;_ylc=X3oDMTJkZTAwc2tsBF9TAzk3NDc2NTkwBGdycElkAzczNjAyMjYEZ3Jwc3BJZAMxNzA1MDA2OTA1BHNlYwNmdHIEc2xrA2hwZgRzdGltZQMxMzM4ODA5ODY3">
        Visit Your Group 
      </a> |
      <a href="http://docs.yahoo.com/info/terms/">
        Yahoo! Groups Terms of Use
      </a> |
      <a href="mailto:[email protected]?subject=Unsubscribe">
       Unsubscribe 
      </a> 
 <br>
    </div>
  <br>

<!-- |**|end egp html banner|**| -->


<div style="color: white; clear: both;"/>__,_._,___</div>
</body>
</html>

--------------070608090500060607090108--