[picocontainer-scm] [5592] java/2.x/trunk/pico: @todo becomes TODO

Revision 5592
Author paul
Date 2010-02-07 20:06:20 -0600 (Sun, 07 Feb 2010)

Log Message

@todo becomes TODO

Modified Paths

- java/2.x/trunk/pico/container/src/java/org/picocontainer/DefaultPicoContainer.java

- java/2.x/trunk/pico/container/src/java/org/picocontainer/monitors/ConsoleComponentMonitor.java

- java/2.x/trunk/pico/container/src/test/org/picocontainer/adapters/SimpleNamedBindingAnnotationTestCase.java

- java/2.x/trunk/pico/container/src/test/org/picocontainer/defaults/issues/Issue0332TestCase.java

- java/2.x/trunk/pico/container/src/test/org/picocontainer/injectors/ConstructorInjectorTestCase.java

- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/behaviors/Assimilating.java

- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/behaviors/Pooled.java

- java/2.x/trunk/pico/gems/src/test/org/picocontainer/gems/behaviors/PooledTestCase.java

- java/2.x/trunk/pico/pom.xml

Diff

Modified: java/2.x/trunk/pico/container/src/java/org/picocontainer/DefaultPicoContainer.java (5591 => 5592)

--- java/2.x/trunk/pico/container/src/java/org/picocontainer/DefaultPicoContainer.java 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/container/src/java/org/picocontainer/DefaultPicoContainer.java 2010-02-08 02:06:20 UTC (rev 5592)
@@ -877,7 +877,7 @@
public MutablePicoContainer addChildContainer(final PicoContainer child) {
checkCircularChildDependencies(child);
if (children.add(child)) {
- // @todo Should only be added if child container has also be started
+ // TODO Should only be added if child container has also be started
if (lifecycleState.isStarted()) {
childrenStarted.add(new WeakReference<PicoContainer>(child));
}

Modified: java/2.x/trunk/pico/container/src/java/org/picocontainer/monitors/ConsoleComponentMonitor.java (5591 => 5592)

--- java/2.x/trunk/pico/container/src/java/org/picocontainer/monitors/ConsoleComponentMonitor.java 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/container/src/java/org/picocontainer/monitors/ConsoleComponentMonitor.java 2010-02-08 02:06:20 UTC (rev 5592)
@@ -33,11 +33,11 @@
/**
* A {@link ComponentMonitor} which writes to a {@link OutputStream}.
* This is typically used to write to a console.
- *
+ * (TODO After serialization, the output printstream is null)
+ *
* @author Paul Hammant
* @author Aslak Helles&oslash;y
* @author Mauro Talevi
- * @todo After serialization, the output printstream is null.
*/
@SuppressWarnings("serial")
public class ConsoleComponentMonitor implements ComponentMonitor, Serializable {

Modified: java/2.x/trunk/pico/container/src/test/org/picocontainer/adapters/SimpleNamedBindingAnnotationTestCase.java (5591 => 5592)

--- java/2.x/trunk/pico/container/src/test/org/picocontainer/adapters/SimpleNamedBindingAnnotationTestCase.java 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/container/src/test/org/picocontainer/adapters/SimpleNamedBindingAnnotationTestCase.java 2010-02-08 02:06:20 UTC (rev 5592)
@@ -123,7 +123,7 @@

@Override
public void verify(PicoContainer container) throws PicoCompositionException {
- // @todo Auto-generated method stub
+ // TODO Auto-generated method stub
}

public T getComponentInstance(PicoContainer container, Type into) throws PicoCompositionException {

Modified: java/2.x/trunk/pico/container/src/test/org/picocontainer/defaults/issues/Issue0332TestCase.java (5591 => 5592)

--- java/2.x/trunk/pico/container/src/test/org/picocontainer/defaults/issues/Issue0332TestCase.java 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/container/src/test/org/picocontainer/defaults/issues/Issue0332TestCase.java 2010-02-08 02:06:20 UTC (rev 5592)
@@ -31,7 +31,7 @@

/**
- * @todo Revisit this for Pico 3.
+ * TODO Revisit this for Pico 3.
*/
@Ignore
@Test

Modified: java/2.x/trunk/pico/container/src/test/org/picocontainer/injectors/ConstructorInjectorTestCase.java (5591 => 5592)

--- java/2.x/trunk/pico/container/src/test/org/picocontainer/injectors/ConstructorInjectorTestCase.java 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/container/src/test/org/picocontainer/injectors/ConstructorInjectorTestCase.java 2010-02-08 02:06:20 UTC (rev 5592)
@@ -380,8 +380,8 @@
}
}

- /**
- * @todo: On some machines, the number of iterations aren't enough.
+ /*
+ * (TODO: On some machines, the number of iterations aren't enough.)
*/
@Test public void testSpeedOfRememberedConstructor() {
long with, without;

Modified: java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/behaviors/Assimilating.java (5591 => 5592)

--- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/behaviors/Assimilating.java 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/behaviors/Assimilating.java 2010-02-08 02:06:20 UTC (rev 5592)
@@ -27,9 +27,9 @@
/**
* Factory for the Assimilated. This factory will create {@link Assimilated} instances for all
* {@link ComponentAdapter} instances created by the delegate. This will assimilate every component for a specific type.
+ * (TODO Since assimilating is taking types that are not the result type, does this mean that we cannot use generics)
*
* @author J&ouml;rg Schaible
- * @todo Since assimilating is taking types that are not the result type, does this mean that we cannot use generics
* for this type? I've been unable to actually get it working.
*/
@SuppressWarnings("serial")

Modified: java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/behaviors/Pooled.java (5591 => 5592)

--- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/behaviors/Pooled.java 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/behaviors/Pooled.java 2010-02-08 02:06:20 UTC (rev 5592)
@@ -254,7 +254,7 @@
*
*/
protected Pooled() {
- // @todo super class should support standard ctor
+ // TODO super class should support standard ctor
super((ComponentAdapter)Null.object(ComponentAdapter.class));
}

@@ -414,7 +414,7 @@
for (Object component : components) {
dispose(component);
}
- // @todo: Release pooled components and clear collection
+ // TODO: Release pooled components and clear collection
}
}

Modified: java/2.x/trunk/pico/gems/src/test/org/picocontainer/gems/behaviors/PooledTestCase.java (5591 => 5592)

--- java/2.x/trunk/pico/gems/src/test/org/picocontainer/gems/behaviors/PooledTestCase.java 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/gems/src/test/org/picocontainer/gems/behaviors/PooledTestCase.java 2010-02-08 02:06:20 UTC (rev 5592)
@@ -322,7 +322,7 @@
picoContainer.start();
picoContainer.stop();
picoContainer.dispose();
- // @todo Move test to AbstractAbstractCATC
+ // TODO Move test to AbstractAbstractCATC
assertEquals("<OneOne>!One", buffer.toString());
}
}
@@ -359,7 +359,7 @@
picoContainer.start();
picoContainer.stop();
picoContainer.dispose();
- // @todo Move test to AbstractAbstractCATC
+ // TODO Move test to AbstractAbstractCATC
assertEquals("<One<TwoTwo>One>!Two!One", buffer.toString());
}
}

Modified: java/2.x/trunk/pico/pom.xml (5591 => 5592)

--- java/2.x/trunk/pico/pom.xml 2010-02-07 20:48:49 UTC (rev 5591)
+++ java/2.x/trunk/pico/pom.xml 2010-02-08 02:06:20 UTC (rev 5592)
@@ -9,7 +9,7 @@
<modules>
<module>container</module>
<module>tck</module>
- <!--module>jsr330-tck</module-->
+ <module>jsr330-tck</module>
<module>gems</module>
</modules>
<organization>

----------

To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email