[picocontainer-scm] [jira] Commented: (PICO-369) generic signature of ComponentAdapter#getComponentImplementation

    [ http://jira.codehaus.org/browse/PICO-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=211585#action_211585 ] 

Giorgio Gallo commented on PICO-369:
------------------------------------

Thanks Paul!! That's perfect (for me)

Honestly I didn't think someone would have worked on this any soon, since it breaks source compatibility - well, I think it does at least :D


As for the Stripes+Pico thing - that will take a bit of a long time...
Stripes does its initialization in a Filter, while the pico-web classes do it in a Listener (meaning stripes is not ready when the listener gets executed)... on the other end, Stripe's filter wraps both request and response and other Stripes classes complain if it finds a "naked" request/response (meaning one can't use much of the functionality of pico-web).
It will be a long time until I can release anything :( and probably a longer one to get my patches accepted by the stripes guys...

> generic signature of ComponentAdapter#getComponentImplementation
> ----------------------------------------------------------------
>
>                 Key: PICO-369
>                 URL: http://jira.codehaus.org/browse/PICO-369
>             Project: PicoContainer
>          Issue Type: Improvement
>          Components: PicoContainer (Java)
>    Affects Versions: 2.9
>            Reporter: Giorgio Gallo
>            Assignee: Paul Hammant
>            Priority: Minor
>             Fix For: 2.10.1
>
>
> The signature of method ComponentAdapter#getComponentImplementation is currently
> Class<T> getComponentImplementation();
> To me it feels like
> Class<? extends T> getComponentImplementation();
> should be used instead, in order to allow (eg) for
> public class MyAdapter implements ComponentAdapter<List> {
>   private Class<? extends List> implementationclass = ArrayList.class;
>   public Class<? extends List> getComponentImplementation() {
>     return implementationclass;
>   }
>   // ...
> }
> (the above is adapted from a real case I got into while integrating pico with stripes - I want to implement an adapter which resolves to whatever ActionBeanContext class is configured in web.xml and so there is no way I can statically type the T of ComponentAdapter)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

<hr/>
<p>
To unsubscribe from this list please visit:
</p>
<p>
    <a href="http://xircles.codehaus.org/manage_email">http://xircles.codehaus.org/manage_email</a>