[picocontainer-scm] [5673] java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors: getLogger() was vulnerable to race conditions and was synchronized.

Revision 5673
Author rimovm
Date 2010-03-30 17:45:03 -0500 (Tue, 30 Mar 2010)

Log Message

getLogger() was vulnerable to race conditions and was synchronized.

Modified Paths

- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/CommonsLoggingComponentMonitor.java

- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/Log4JComponentMonitor.java

- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/Slf4jComponentMonitor.java

Diff

Modified: java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/CommonsLoggingComponentMonitor.java (5672 => 5673)

--- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/CommonsLoggingComponentMonitor.java 2010-03-30 22:44:00 UTC (rev 5672)
+++ java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/CommonsLoggingComponentMonitor.java 2010-03-30 22:45:03 UTC (rev 5673)
@@ -239,7 +239,7 @@
* @param member constructor/method/field who's callback is required.
* @return the Commons logging instance.
*/
- protected Log getLog(final Member member) {
+ protected synchronized Log getLog(final Member member) {
if ( log != null ){
return log;
}

Modified: java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/Log4JComponentMonitor.java (5672 => 5673)

--- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/Log4JComponentMonitor.java 2010-03-30 22:44:00 UTC (rev 5672)
+++ java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/Log4JComponentMonitor.java 2010-03-30 22:45:03 UTC (rev 5673)
@@ -239,7 +239,7 @@
return delegate.newBehavior(behavior);
}

- protected Logger getLogger(final Member member) {
+ protected synchronized Logger getLogger(final Member member) {
if ( logger != null ){
return logger;
}

Modified: java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/Slf4jComponentMonitor.java (5672 => 5673)

--- java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/Slf4jComponentMonitor.java 2010-03-30 22:44:00 UTC (rev 5672)
+++ java/2.x/trunk/pico/gems/src/java/org/picocontainer/gems/monitors/Slf4jComponentMonitor.java 2010-03-30 22:45:03 UTC (rev 5673)
@@ -278,7 +278,7 @@
* Source method/constructor, etc being instantiated.
* @return an appropriate logger instance for this callback.
*/
- protected Logger getLogger(final Member member) {
+ protected synchronized Logger getLogger(final Member member) {
if (logger != null) {
return logger;
}

----------

To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email