[picocontainer-scm] [jira] Created: (PICO-376) Kill Container Probably Won't Remove Child from Parent

Kill Container Probably Won't Remove Child from Parent
------------------------------------------------------

                 Key: PICO-376
                 URL: http://jira.codehaus.org/browse/PICO-376
             Project: PicoContainer
          Issue Type: Bug
          Components: PicoContainer Scripting
            Reporter: Michael Rimov
             Fix For: 3.0


AbstractContainerBuilderContainerBuilder.killContainer() has the following code:

{code}
        PicoContainer parent = container.getParent();
        if (parent != null && parent instanceof MutablePicoContainer) {
	    synchronized (parent) {
	          ((MutablePicoContainer) parent).removeChildContainer(container);
		}
        }

{code}

Only problem is we have a situation like this:

MutablePico parent = <blah>
MutablePico child = parent.makeChildContainer();

then containerBuilder.killContainer(child)  will NOT remove the child from the parent (possibly resulting in a memory leak. because parent will be an ImmutablePicoContainer.

I'll be checking in a test case that demonstrates this shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

<hr/>
<p>
To unsubscribe from this list please visit:
</p>
<p>
    <a href="http://xircles.codehaus.org/manage_email">http://xircles.codehaus.org/manage_email</a>