[picocontainer-scm] [scm-git][1/1] Just because the test passed doesn't mean it's correct. Doh! :D
Michael Rimov <git-yCVjj/[email protected]> Tue, 25 Jun 2013 13:13:50 -0500 (CDT)
| Newsgroups | gmane.comp.java.picocontainer.cvs |
|---|---|
| Message-ID | <[email protected]> |
--2c98c132f9a10b531008ecf99a1a0ea7425b5128 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline commit 608a3497560f7d2604919ad8c120d609eacab3af=0AAuthor: Michael Rimov= <[email protected]>=0AAuthorDate: Tue, 25 Jun 2013 11:13:11 -0700= =0ACommit: Michael Rimov <[email protected]>=0ACommitDate: Tue,= 25 Jun 2013 11:13:11 -0700=0A=0A Just because the test passed doesn't m= ean it's correct. Doh! :D=0A=0Adiff --git a/web/examples/struts2-webapp-wi= th-pwr/src/test/com/picocontainer/web/sample/struts2/pwr/selenium/ListAddCh= eese.java b/web/examples/struts2-webapp-with-pwr/src/test/com/picocontainer= /web/sample/struts2/pwr/selenium/ListAddCheese.java=0Aindex d561ed0..56bf4c= 8 100644=0A--- a/web/examples/struts2-webapp-with-pwr/src/test/com/picocont= ainer/web/sample/struts2/pwr/selenium/ListAddCheese.java=0A+++ b/web/exampl= es/struts2-webapp-with-pwr/src/test/com/picocontainer/web/sample/struts2/pw= r/selenium/ListAddCheese.java=0A@@ -19,7 +19,8 @@ public class ListAddChees= e {=0A =0A =0A assertTrue(selenium.isElementPresent("name=3Dcount"));= =0A- selenium.waitForCondition("selenium.browserbot.getCurrentWindow().doc= ument.countForm.count.value =3D=3D 4", "10");=0A+ selenium.waitForConditio= n("selenium.browserbot.getCurrentWindow().document.countForm.count.value = =3D=3D '4'", "10000");=0A+ assertEquals("4", selenium.getValue("name=3Dcou= nt"));=0A }=0A =0A =0A=0A=0A=0A= --2c98c132f9a10b531008ecf99a1a0ea7425b5128 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w= 3.org/TR/REC-html40/loose.dtd">=0A<html style=3D"font-size: 12px;">=0A<head= ><meta http-equiv=3D"Content-type" content=3D"text/html; charset=3Dutf-8"><= /head>=0A<body style=3D"font-size: 12px;">=0A<style type=3D"text/css">=0Adt= :after { content: ':' !important; }=0A></style>=0A<dl class=3D"title" style= =3D"font-size: 12px; font-family: Verdana; background-color: #ddd; padding:= 10px;">=0A<dt style=3D"font-size: 12px; float: left; font-weight: bold; mi= n-width: 6em;">Commit</dt>=0A<dd style=3D"font-size: 12px;">608a3497560f7d2= 604919ad8c120d609eacab3af</dd>=0A<dt style=3D"font-size: 12px; float: left;= font-weight: bold; min-width: 6em;">Branch</dt>=0A<dd style=3D"font-size: = 12px;">master</dd>=0A<dt style=3D"font-size: 12px; float: left; font-weight= : bold; min-width: 6em;">Author</dt>=0A<dd style=3D"font-size: 12px;">Micha= el Rimov <[email protected]></dd>=0A<dt style=3D"font-size: 1= 2px; float: left; font-weight: bold; min-width: 6em;">Date</dt>=0A<dd style= =3D"font-size: 12px;">Tue, 25 Jun 2013 11:13:11 -0700</dd>=0A<dt style=3D"f= ont-size: 12px; float: left; font-weight: bold; min-width: 6em;">Message</d= t>=0A<dd class=3D"" style=3D"font-size: 12px;">Just because the test passed= doesn't mean it's correct. Doh! :D</dd>=0A</dl>=0A<h2 id=3D"web/examples/= struts2-webapp-with-pwr/src/test/com/picocontainer/web/sample/struts2/pwr/s= elenium/ListAddCheese.java" style=3D"font-size: 12px; font-family: Verdana;= font-weight: bold; line-height: 25px; margin-bottom: 2px; padding-left: 5p= x; background-color: #bbb;">Changed file web/examples/struts2-webapp-with-p= wr/src/test/com/picocontainer/web/sample/struts2/pwr/selenium/ListAddCheese= .java</h2>=0A=0A<table style=3D"font-size: 12px; width: 100%; border-collap= se: collapse;">=0A<tr style=3D"font-size: 12px;">=0A<td class=3D"ln" style= =3D"font-size: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono','= Monaco','Courier',monospace; width: 23px; text-align: right; background-col= or: #ccc;" align=3D"right" bgcolor=3D"#ccc">19</td>=0A<td class=3D"ln" styl= e=3D"font-size: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono',= 'Monaco','Courier',monospace; width: 23px; text-align: right; background-co= lor: #ccc;" align=3D"right" bgcolor=3D"#ccc">19</td>=0A<td style=3D"font-si= ze: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Co= urier',monospace;">=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0</td>=0A= </tr>=0A<tr style=3D"font-size: 12px;">=0A<td class=3D"ln" style=3D"font-si= ze: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Co= urier',monospace; width: 23px; text-align: right; background-color: #ccc;" = align=3D"right" bgcolor=3D"#ccc">20</td>=0A<td class=3D"ln" style=3D"font-s= ize: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','C= ourier',monospace; width: 23px; text-align: right; background-color: #ccc;"= align=3D"right" bgcolor=3D"#ccc">20</td>=0A<td style=3D"font-size: 12px; c= olor: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',mono= space;">=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0</td>=0A</tr>=0A<tr= style=3D"font-size: 12px;">=0A<td class=3D"ln" style=3D"font-size: 12px; c= olor: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',mono= space; width: 23px; text-align: right; background-color: #ccc;" align=3D"ri= ght" bgcolor=3D"#ccc">21</td>=0A<td class=3D"ln" style=3D"font-size: 12px; = color: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',mon= ospace; width: 23px; text-align: right; background-color: #ccc;" align=3D"r= ight" bgcolor=3D"#ccc">21</td>=0A<td style=3D"font-size: 12px; color: #000;= font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',monospace;">=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0assertTrue(selenium.isElementP= resent("name=3Dcount"));</td>=0A</tr>=0A<tr class=3D"r" style=3D"font-size:= 12px; background-color: #fdd;" bgcolor=3D"#fdd">=0A<td class=3D"ln" style= =3D"font-size: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono','= Monaco','Courier',monospace; width: 23px; text-align: right; background-col= or: #ccc;" align=3D"right" bgcolor=3D"#ccc">22</td>=0A<td class=3D"ln" styl= e=3D"font-size: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono',= 'Monaco','Courier',monospace; width: 23px; text-align: right; background-co= lor: #ccc;" align=3D"right" bgcolor=3D"#ccc"></td>=0A<td style=3D"font-size= : 12px; color: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Cour= ier',monospace;">=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sele= nium.waitForCondition("selenium.browserbot.getCurrentWindow().document.coun= tForm.count.value=C2=A0=3D=3D=C2=A04",=C2=A0"<span class=3D"rr" style=3D"fo= nt-size: 12px; background-color: #faa;">10</span>");</td>=0A</tr>=0A<tr cla= ss=3D"a" style=3D"font-size: 12px; background-color: #dfd;" bgcolor=3D"#dfd= ">=0A<td class=3D"ln" style=3D"font-size: 12px; color: #000; font-family: '= Bitstream Vera Sans Mono','Monaco','Courier',monospace; width: 23px; text-a= lign: right; background-color: #ccc;" align=3D"right" bgcolor=3D"#ccc"></td= >=0A<td class=3D"ln" style=3D"font-size: 12px; color: #000; font-family: 'B= itstream Vera Sans Mono','Monaco','Courier',monospace; width: 23px; text-al= ign: right; background-color: #ccc;" align=3D"right" bgcolor=3D"#ccc">22</t= d>=0A<td style=3D"font-size: 12px; color: #000; font-family: 'Bitstream Ver= a Sans Mono','Monaco','Courier',monospace;">=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0selenium.waitForCondition("selenium.browserbot.getC= urrentWindow().document.countForm.count.value=C2=A0=3D=3D=C2=A0<span class= =3D"aa" style=3D"font-size: 12px; background-color: #afa;">'</span>4<span c= lass=3D"aa" style=3D"font-size: 12px; background-color: #afa;">'</span>",= =C2=A0"<span class=3D"aa" style=3D"font-size: 12px; background-color: #afa;= ">10000</span>"<span class=3D"aa" style=3D"font-size: 12px; background-colo= r: #afa;">);</span>=0A</td>=0A</tr>=0A<tr class=3D"a" style=3D"font-size: 1= 2px; background-color: #dfd;" bgcolor=3D"#dfd">=0A<td class=3D"ln" style=3D= "font-size: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono','Mon= aco','Courier',monospace; width: 23px; text-align: right; background-color:= #ccc;" align=3D"right" bgcolor=3D"#ccc"></td>=0A<td class=3D"ln" style=3D"= font-size: 12px; color: #000; font-family: 'Bitstream Vera Sans Mono','Mona= co','Courier',monospace; width: 23px; text-align: right; background-color: = #ccc;" align=3D"right" bgcolor=3D"#ccc">23</td>=0A<td style=3D"font-size: 1= 2px; color: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier= ',monospace;">=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0<span c= lass=3D"aa" style=3D"font-size: 12px; background-color: #afa;">assertEquals= ("4",=C2=A0selenium.getValue("name=3Dcount")</span>);</td>=0A</tr>=0A<tr st= yle=3D"font-size: 12px;">=0A<td class=3D"ln" style=3D"font-size: 12px; colo= r: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',monospa= ce; width: 23px; text-align: right; background-color: #ccc;" align=3D"right= " bgcolor=3D"#ccc">23</td>=0A<td class=3D"ln" style=3D"font-size: 12px; col= or: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',monosp= ace; width: 23px; text-align: right; background-color: #ccc;" align=3D"righ= t" bgcolor=3D"#ccc">24</td>=0A<td style=3D"font-size: 12px; color: #000; fo= nt-family: 'Bitstream Vera Sans Mono','Monaco','Courier',monospace;">=C2=A0= =C2=A0=C2=A0=C2=A0}</td>=0A</tr>=0A<tr style=3D"font-size: 12px;">=0A<td cl= ass=3D"ln" style=3D"font-size: 12px; color: #000; font-family: 'Bitstream V= era Sans Mono','Monaco','Courier',monospace; width: 23px; text-align: right= ; background-color: #ccc;" align=3D"right" bgcolor=3D"#ccc">24</td>=0A<td c= lass=3D"ln" style=3D"font-size: 12px; color: #000; font-family: 'Bitstream = Vera Sans Mono','Monaco','Courier',monospace; width: 23px; text-align: righ= t; background-color: #ccc;" align=3D"right" bgcolor=3D"#ccc">25</td>=0A<td = style=3D"font-size: 12px; color: #000; font-family: 'Bitstream Vera Sans Mo= no','Monaco','Courier',monospace;">=C2=A0=C2=A0=C2=A0=C2=A0</td>=0A</tr>=0A= <tr style=3D"font-size: 12px;">=0A<td class=3D"ln" style=3D"font-size: 12px= ; color: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',m= onospace; width: 23px; text-align: right; background-color: #ccc;" align=3D= "right" bgcolor=3D"#ccc">25</td>=0A<td class=3D"ln" style=3D"font-size: 12p= x; color: #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',= monospace; width: 23px; text-align: right; background-color: #ccc;" align= =3D"right" bgcolor=3D"#ccc">26</td>=0A<td style=3D"font-size: 12px; color: = #000; font-family: 'Bitstream Vera Sans Mono','Monaco','Courier',monospace;= ">=C2=A0=C2=A0=C2=A0=C2=A0</td>=0A</tr>=0A</table>=0A<br style=3D"font-size= : 12px;"><br style=3D"font-size: 12px;">=0A</body>=0A</html>=0A= --2c98c132f9a10b531008ecf99a1a0ea7425b5128--