RE: [picocontainer-dev] assymetry in resolution ( by key / by type )

Konstantin Priblouda wrote:
> --- Jörg Schaible <[email protected]>
> wrote:
> 
>> Paul Hammant wrote:
>>> Konstantin,
>>> 
>>> Can you write some testcases for trunk that illustrate the curious
>>> feature ? 
>>> 
>>> If there's implied kinks to iron out, we can discuss them around one
>>> more more test methods :-)
>> 
>> The test cases are already available. Simply try to
>> change the behaviour und you'll see which ones fail
>> ;-)
> 
> 
> Did a quck check:

You solved it the other way round! I tried to resolve always against the parent.

> ----------------%<---------------
> Results :
> 
> Failed tests:
> 
> testShouldCreateBowlWith2CodsOnly(org.picocontainer.doc.advanc
> ed.MapsTestCase) 


This is critical. The collections are explicitly used to gather all components of a type. It will certainly break some of my apps!


> Tests in error:
> 
> testWillRemoveComponentsWithMatchingKeyFromParent(org.picocont
> ainer.defaults.CollectionComponentParameterTestCase)
> 
> testAsParentContainer(org.picocontainer.containers.CommandLine
> ArgumentsPicoContainerTestCase)
> 
> testUnsatisfiableIfNoSuitableTyesForInjection(org.picocontaine
> r.containers.CommandLineArgumentsPicoContainerTestCase)
> 
> testParentContainerWithComponentWithEqualKeyShouldBeShadowedBy
> Child(org.picocontainer.defaults.ChildContainerTestCase)
> 
> Tests run: 608, Failures: 1, Errors: 4, Skipped: 0
> ---------------%<--------------
> 
> It seems that nothing global happens here.

For me it already does!

- Jörg

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email