Re: [picocontainer-dev] Chg 4832 - Generic collections process like arrays do now.

I wouldn't lose too much sleep over changing the signature.  Like you
say, Parameter is quite a low-level interface that not many users will
be implementing.

Whilst you're there, how about removing the raw types from the
interface too?  e.g. ComponentAdapter to ComponentAdapter<?>, Class to
Class<?>

Cheers,

Mark

2008/7/6 Paul Hammant <[email protected]>:
> Paired with Pete yesterday, a change to Parameter has allowed components to
> have generic collections as a declared injectable.
>
> We're at a crossroads though, there are three methods in Parameter that need
> to change somehow:
>
>  Object resolveInstance(PicoContainer container, ComponentAdapter adapter,
> Class expectedType  ...etc
>  boolean isResolvable(PicoContainer container, ComponentAdapter adapter,
> Class expectedType  ...etc
>  void verify(PicoContainer container,  ComponentAdapter adapter, Class
> expectedType  ...etc
>
> We could change the third param to Type from Class
>
>  Object resolveInstance(PicoContainer container, ComponentAdapter adapter,
> Type expectedType  ...etc
>  boolean isResolvable(PicoContainer container, ComponentAdapter adapter,
> Type expectedType  ...etc
>  void verify(PicoContainer container,  ComponentAdapter adapter, Type
> expectedType  ...etc
>
> Or we could do an overloaded route by having a second set of three and use
> deprecated on the old three.
>
> The current commit has changed two and overloaded one.
>
> My view is that PC and MPC are the interfaces to be more reverent about, and
> that Parameter is more marginal for backwards compatibility.
>
> Thoughts?
>
> Regards,
>
> - Paul
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>   http://xircles.codehaus.org/manage_email
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email