Re: [picocontainer-dev] Commit 5799 Race Condition Fix....
Paul Hammant <[email protected]> Mon, 7 Nov 2011 19:31:41 -0600
| Newsgroups | gmane.comp.java.picocontainer.devel |
|---|---|
| Message-ID | <CA+298Uj99emDqcQ7gFzTp7rVEwOutUUYMD1pgiR_+ak7n9tuxw@mail.gmail.com> |
--f46d044271223001d304b12f223a Content-Type: text/plain; charset=ISO-8859-1 I eliminated the situation I was getting in a production deployment. I'm not sure what you mean Mike. -ph On Mon, Nov 7, 2011 at 6:43 PM, Michael Rimov <[email protected]> wrote: > Paul, > > I was looking @ the diffs.... and this code in Iterative adapter: > > if (injectionMembers == null) { > synchronized (this) { > if (injectionMembers == null) { > initializeInjectionMembersAndTypeLists(); > } > } > } > > Isn't that double-check locking and not really solving the race condition? > Or is Boolean assignment exempt from this kind of situation? > > > -Mike > > > > -----Original Message----- > From: Paul Hammant [mailto:[email protected]] > Sent: Monday, November 07, 2011 11:53 AM > To: dev-qxt/[email protected] > Subject: Re: [picocontainer-dev] Release of Pico 2.14 > > My bad - I've only just done the nexus 'approval'. Give it four hours or > so. Meanwhile build from source : > > > http://svn.codehaus.org/picocontainer/java/2.x/tags/picocontainer-2.14/ > mvn clean install -DskipTests -Preporting > > On Mon, Nov 7, 2011 at 1:28 PM, Simon Brandhof <[email protected]> > wrote: > > Hi Paul, > > > > Will this release be deployed in Maven repository ? > > > > Thanks > > > > > > On 7 November 2011 19:04, Paul Hammant <[email protected]> wrote: > >> > >> Hey Mike. The answer is I'm not sure. It's pretty up to date - go > >> for it: The stuff that's in the latest release isn't in 3.x / Git > >> yet. > >> > >> - Paul > >> > >> On Mon, Nov 7, 2011 at 10:38 AM, Michael Rimov > >> <[email protected]> > >> wrote: > >> > Hey Paul, > >> > > >> > What is the last change you ported over to Pico 3? > >> > > >> > I'll be happy to manually port based on the diffs, but I wanted to > >> > make sure before I started that I wasn't duplicating efforts. > >> > > >> > >> --------------------------------------------------------------------- > >> To unsubscribe from this list, please visit: > >> > >> http://xircles.codehaus.org/manage_email > >> > >> > > > > > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > --f46d044271223001d304b12f223a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I eliminated the situation I was getting in a production deployment. =A0I&#= 39;m not sure what you mean Mike.<div><br></div><div>-ph<br><br><div class= =3D"gmail_quote">On Mon, Nov 7, 2011 at 6:43 PM, Michael Rimov <span dir=3D= "ltr"><<a href=3D"mailto:[email protected]">[email protected]</a= >></span> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex;">Paul,<br> <br> I was looking @ the diffs.... =A0and this code in Iterative adapter:<br> <br> =A0 =A0 =A0 if (injectionMembers =3D=3D null) {<br> =A0 =A0 =A0 =A0 =A0 =A0synchronized (this) {<br> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (injectionMembers =3D=3D null) {<br> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0initializeInjectionMembersAndTypeLi= sts();<br> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}<br> =A0 =A0 =A0 =A0 =A0 =A0}<br> =A0 =A0 =A0 =A0}<br> <br> Isn't that double-check locking and not really solving the race conditi= on?<br> Or is Boolean assignment exempt from this kind of situation?<br> <br> <br> -Mike<br> <br> <br> <br> -----Original Message-----<br> From: Paul Hammant [mailto:<a href=3D"mailto:[email protected]">paul@hammant= .org</a>]<br> Sent: Monday, November 07, 2011 11:53 AM<br> To: <a href=3D"mailto:dev-qxt/[email protected]">dev-qxt/[email protected]= ehaus.org</a><br> Subject: Re: [picocontainer-dev] Release of Pico 2.14<br> <br> My bad - I've only just done the nexus 'approval'. =A0Give it f= our hours or<br> so. =A0Meanwhile build from source :<br> <br> =A0 =A0 <a href=3D"http://svn.codehaus.org/picocontainer/java/2.x/tags/pic= ocontainer-2.14/" target=3D"_blank">http://svn.codehaus.org/picocontainer/j= ava/2.x/tags/picocontainer-2.14/</a><br> =A0 =A0 mvn clean install -DskipTests -Preporting<br> <br> On Mon, Nov 7, 2011 at 1:28 PM, Simon Brandhof <<a href=3D"mailto:simon.= [email protected]">[email protected]</a>><br> wrote:<br> > Hi Paul,<br> ><br> > Will this release be deployed in Maven repository ?<br> ><br> > Thanks<br> ><br> ><br> > On 7 November 2011 19:04, Paul Hammant <<a href=3D"mailto:paul@hamm= ant.org">[email protected]</a>> wrote:<br> >><br> >> Hey Mike. =A0The answer is I'm not sure. =A0It's pretty up= to date - go<br> >> for it: =A0The stuff that's in the latest release isn't in= 3.x / Git<br> >> yet.<br> >><br> >> - Paul<br> >><br> >> On Mon, Nov 7, 2011 at 10:38 AM, Michael Rimov<br> >> <<a href=3D"mailto:[email protected]">[email protected]= </a>><br> >> wrote:<br> >> > Hey Paul,<br> >> ><br> >> > What is the last change you ported over to Pico 3?<br> >> ><br> >> > I'll be happy to manually port based on the diffs, but I = wanted to<br> >> > make sure before I started that I wasn't duplicating effo= rts.<br> >> ><br> >><br> >> ------------------------------------------------------------------= ---<br> >> To unsubscribe from this list, please visit:<br> >><br> >> =A0 =A0<a href=3D"http://xircles.codehaus.org/manage_email" target= =3D"_blank">http://xircles.codehaus.org/manage_email</a><br> >><br> >><br> ><br> ><br> <br> ---------------------------------------------------------------------<br> To unsubscribe from this list, please visit:<br> <br> =A0 =A0<a href=3D"http://xircles.codehaus.org/manage_email" target=3D"_bla= nk">http://xircles.codehaus.org/manage_email</a><br> <br> <br> <br> ---------------------------------------------------------------------<br> To unsubscribe from this list, please visit:<br> <br> =A0 =A0<a href=3D"http://xircles.codehaus.org/manage_email" target=3D"_bla= nk">http://xircles.codehaus.org/manage_email</a><br> <br> <br> </blockquote></div><br></div> --f46d044271223001d304b12f223a--