Re: [picocontainer-dev] JSON Pico container

--047d7b33cac88fa44c04ee61d6d9
Content-Type: text/plain; charset=ISO-8859-1

I've processed the pull-request, reworked it a little, and relocated it to
script/json/* (along side the Groovy, JRuby, XML ones).

There's a bunch of code that's not covered.  Can you share any more of your
use cases, so that we could end up with more comprehensive tests?

Also, there's code in the json to say what type of parameter things are
(int, long, double etc).  Is there another way we could work things such
that the declarations of that kind are not needed?  PicoContainer has a
class called BuildInConverters that could auto convert strings to params,
and use the order of the parameter to make the conversion.  It could be
that your use case is pretty strong, and this would be an additonal way of
marking up trees.

Also, take a look at the nesting of containers in
https://github.com/picocontainer/picocontainer/blob/master/booter/src/test/composition.groovyand
have a think about whether we could evolve the json grammar in that
*nested* direction. (see also
https://github.com/picocontainer/picocontainer/blob/master/script/script-groovy/src/test/com/picocontainer/script/groovy/GroovyNodeBuilderTestCase.javaand
https://github.com/picocontainer/picocontainer/blob/master/script/script-groovy/src/test/com/picocontainer/script/groovy/GroovyContainerBuilderTestCase.java
)

Great work Serban:)

-ph


On Fri, Dec 13, 2013 at 8:50 PM, Serban Iordache <[email protected]>wrote:

> I've just sent the pull request for PicoContainer 3.0.
>
>
> Attached is the patch for PicoContainer 2.x.
>
>
> Serban
>
>
> ------------------------------
> Date: Fri, 13 Dec 2013 14:10:01 -0500
> From: [email protected]
> To: dev-qxt/[email protected]
> Subject: Re: [picocontainer-dev] JSON Pico container
>
>
> If you've got JUnit tests that shows it in use, feel free to donate it -
> we're more than happy to facilitate other people's use-cases.
>
> As it happens we're on the cusp of releasing PicoContainer 3, but you may
> have a strong preference for doing this for PicoContainer 2.0, and we're
> happy with cooperating with that agenda too.  Patch-files for Pico2
> (imperfect Subversion world).  A Github fork (and pull request) for
> PicoContainer 3, if your happy with an implicit delay on release.
>
> - Paul
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>     http://xircles.codehaus.org/manage_email
>
>

--047d7b33cac88fa44c04ee61d6d9
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I&#39;ve processed the pull-request, reworked it a little,=
 and relocated it to script/json/* (along side the Groovy, JRuby, XML ones)=
.<div><br></div><div>There&#39;s a bunch of code that&#39;s not covered. =
=A0Can you share any more of your use cases, so that we could end up with m=
ore comprehensive tests?</div>
<div><br></div><div>Also, there&#39;s code in the json to say what type of =
parameter things are (int, long, double etc). =A0Is there another way we co=
uld work things such that the declarations of that kind are not needed? =A0=
PicoContainer has a class called BuildInConverters that could auto convert =
strings to params, and use the order of the parameter to make the conversio=
n. =A0It could be that your use case is pretty strong, and this would be an=
 additonal way of marking up trees.</div>
<div><br></div><div>Also, take a look at the nesting of containers in=A0<a =
href=3D"https://github.com/picocontainer/picocontainer/blob/master/booter/s=
rc/test/composition.groovy">https://github.com/picocontainer/picocontainer/=
blob/master/booter/src/test/composition.groovy</a> and have a think about w=
hether we could evolve the json grammar in that *nested* direction. (see al=
so=A0<a href=3D"https://github.com/picocontainer/picocontainer/blob/master/=
script/script-groovy/src/test/com/picocontainer/script/groovy/GroovyNodeBui=
lderTestCase.java">https://github.com/picocontainer/picocontainer/blob/mast=
er/script/script-groovy/src/test/com/picocontainer/script/groovy/GroovyNode=
BuilderTestCase.java</a> and=A0<a href=3D"https://github.com/picocontainer/=
picocontainer/blob/master/script/script-groovy/src/test/com/picocontainer/s=
cript/groovy/GroovyContainerBuilderTestCase.java">https://github.com/picoco=
ntainer/picocontainer/blob/master/script/script-groovy/src/test/com/picocon=
tainer/script/groovy/GroovyContainerBuilderTestCase.java</a>)</div>
<div><br></div><div>Great work Serban:)</div><div><br></div><div>-ph</div><=
/div><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Fri, =
Dec 13, 2013 at 8:50 PM, Serban Iordache <span dir=3D"ltr">&lt;<a href=3D"m=
ailto:[email protected]" target=3D"_blank">[email protected]</a>&gt;<=
/span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">


<div><div dir=3D"ltr"><pre><pre><font face=3D"Calibri, sans-serif"><span st=
yle=3D"line-height:21px;white-space:normal">I&#39;ve just sent the pull req=
uest for PicoContainer 3.0.</span></font></pre><pre><font face=3D"Calibri, =
sans-serif"><span style=3D"line-height:21px;white-space:normal"><br>
</span></font></pre><pre><font face=3D"Calibri, sans-serif"><span style=3D"=
line-height:21px;white-space:normal">Attached is the patch for PicoContaine=
r 2.x.</span></font></pre><pre style=3D"color:rgb(68,68,68);font-family:Cal=
ibri,sans-serif;font-size:15px;line-height:21px;white-space:normal">
<br></pre></pre><pre style=3D"line-height:21px;white-space:normal;color:rgb=
(68,68,68);font-size:15px"><span style=3D"color:rgb(0,0,0);font-family:Cali=
bri,sans-serif;font-size:12pt">Serban</span></pre><pre style=3D"line-height=
:21px;white-space:normal;color:rgb(68,68,68);font-size:15px">
<span style=3D"color:rgb(0,0,0);font-family:Calibri,sans-serif;font-size:12=
pt"><br></span></pre><div><div><hr>Date: Fri, 13 Dec 2013 14:10:01 -0500<br=
>From: <a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]=
rg</a><br>
To: <a href=3D"mailto:dev-qxt/[email protected]" target=3D"_blank">dev=
@picocontainer.codehaus.org</a><br>Subject: Re: [picocontainer-dev] JSON Pi=
co container<div class=3D"im"><br><br><div dir=3D"ltr">If you&#39;ve got JU=
nit tests that shows it in use, feel free to donate it - we&#39;re more tha=
n happy to facilitate other people&#39;s use-cases.<div>
<br></div><div>As it happens we&#39;re on the cusp of releasing PicoContain=
er 3, but you may have a strong preference for doing this for PicoContainer=
 2.0, and we&#39;re happy with cooperating with that agenda too. =A0Patch-f=
iles for Pico2 (imperfect Subversion world). =A0A Github fork (and pull req=
uest) for PicoContainer 3, if your happy with an implicit delay on release.=
</div>

<div><br></div><div>- Paul</div></div><div><br></div></div></div></div> 		 =
	   		  </div></div>
<br><br>
---------------------------------------------------------------------<br>
To unsubscribe from this list, please visit:<br>
<br>
=A0 =A0 <a href=3D"http://xircles.codehaus.org/manage_email" target=3D"_bla=
nk">http://xircles.codehaus.org/manage_email</a><br>
<br></blockquote></div><br></div>

--047d7b33cac88fa44c04ee61d6d9--