Re: Code format
Karl Wettin <[email protected]> Tue, 12 Aug 2014 19:13:50 +0200
| Newsgroups | gmane.comp.java.prevayler |
|---|---|
| Message-ID | <[email protected]> |
Just merged! On 11 Aug 2014, at 23:23, Karl Wettin <[email protected]> wrote: > https://github.com/jsampson/prevayler/pull/8 > > Comments? > > > On 11 Aug 2014, at 21:31, Justin Sampson <[email protected]> wrote: > >> Go for it. I might quibble over some style details, but as I'm an inactive developer I'll keep my mouth shut. :) >> >> -Justin >> >> >> -----Original Message----- >> From: Karl Wettin [mailto:[email protected]] >> Sent: Monday, August 11, 2014 9:15 AM >> To: Open discussion about the Prevayler project. >> Subject: Re: [Prevayler-discussion] Code format >> >> As long as there are no objections, sure. >> >> On 11 Aug 2014, at 18:07, Klaus Wuestefeld <[email protected]> wrote: >> >>> Hi Karl, will you do it? >>> >>> On Sun, Aug 10, 2014 at 5:52 PM, Christian Stein <[email protected]> wrote: >>>> +1 for reformat and optimize imports. >>>> +2 for 2 spaces. ;-) >>>> >>>> Cheers, >>>> Christian >>>> >>>> >>>> On Sun, Aug 10, 2014 at 10:50 PM, Karl Wettin <[email protected]> >>>> wrote: >>>>> >>>>> I was just about to post a patch to the list as a suggestion when I >>>>> noticed a lot of mix with tabs and spaces for indentation of the code, >>>>> rendering it really hard to read my changes. >>>>> >>>>> How about a update of the codebase in which we reformat all code and >>>>> optimize imports? >>>>> >>>>> I vote for 2 spaces indentation, but what ever as long as it is uniform >>>>> trough out the project. >>>>> >>>>> >>>>> >>>>> karl >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> To unsubscribe go to the end of this page: http://lists.sourceforge.net/lists/listinfo/prevayler-discussion >> _______________________________________________ >> "Databases in Memoriam" -- http://www.prevayler.org > ------------------------------------------------------------------------------ _______________________________________________ To unsubscribe go to the end of this page: http://lists.sourceforge.net/lists/listinfo/prevayler-discussion _______________________________________________ "Databases in Memoriam" -- http://www.prevayler.org