Re: MediaFileView.jsp

 > looks like a copy and paste bug on first glance. However deleting 
folders actually works, right? I ran a quick test and the folder is gone.

Yes it works, but I get this error in the console (forgot to add this to 
the first email) after delete:

Uncaught TypeError: document.bookmarks is undefined
     onDeleteFolder 
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:956
     onclick 
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:1

##

 >Its called Blogroll...

OK name change.

Cheers Greg

On 09/08/2021 17:46, Michael Bien wrote:
> On 09.08.21 09:51, Greg Huber wrote:
>> Spotted this one when deleting a folder:
>>
>> MediaFileView.jsp
>>
>> function onDeleteFolder() {
>>         if (confirm("<s:text name='mediaFile.deleteFolder.confirm' 
>> />")) {
>>             document.bookmarks.action = '<s:url 
>> action="mediaFileView!deleteFolder" />';
>>             document.bookmarks.submit();
>>         }
>>     }
>>
>> guess it should be: document.mediaFileViewForm.action and 
>> document.mediaFileViewForm.submit();
>
> looks like a copy and paste bug on first glance. However deleting 
> folders actually works, right? I ran a quick test and the folder is gone.
>
>
>>
>> Also where is the bookmarks page link now?  editor-menu.xml, for 
>> weblogPerms="admin"
>>
>>  <!-- globalPerms="login" -->
>>         <menu-item action="bookmarks"
>>                    name="tabbedmenu.bookmarks.allFolders"
>>                    weblogPerms="admin"
>> subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport" 
>> />
>
> Its called Blogroll in the menu 
> (/roller-ui/authoring/bookmarks.rol?weblog=blog)
>
> the admin user might not have this menu unless the admin has a blog too.
>
> best regards,
>
> michael
>