Re: VOTE: Release RC #2 as Apache Roller 6.1.0

i updated the container file so that signals are properly propagated to 
the process (e.g ctrl+c or docker stop) which makes testing easier. 
Tried it a few times but never saw the error, only the async logger 
warning on shutdown.

https://github.com/apache/roller/pull/110

regards,
michael

On 20.12.21 07:04, Greg Huber wrote:
> It was a tomcat start and stop, no deploy/redeploy.  Seems to do it 
> all the time.
>
> On 19/12/2021 10:46, Michael Bien wrote:
>> this looks like you redeployed or undeployed roller?
>>
>> App/web servers don't like it when unmanaged threads are started, 
>> AsyncAppender uses its own thread and the server noticed this i suppose.
>>
>> see config:
>> https://github.com/apache/roller/blob/master/app/src/main/resources/log4j2.xml#L62-L65 
>>
>> If you remove this part and replace "asyncRoller" with "roller" you 
>> shouldn't see the warning anymore.
>>
>> The eclipse persistence error is probably caused by the undeployment 
>> too.
>>
>> This is most likely harmless, unless you want to constantly redeploy 
>> roller. Most web/app servers these days are used like a runtime in a 
>> 1:1 manner and are started/stopped with the application (in a 
>> container).
>>
>> -michael
>>
>>
>> On 19.12.21 10:28, Greg Huber wrote:
>>> ....Although I now see this in the logs (17 was a maintenance release?)
>>>
>>>
>>> WARNING: An illegal reflective access operation has occurred
>>> WARNING: Illegal reflective access by 
>>> org.apache.catalina.loader.WebappClassLoaderBase 
>>> (file:/../apache-tomcat-9.0.56/lib/catalina.jar) to field 
>>> java.io.ObjectStreamClass$Caches.localDescs
>>> WARNING: Please consider reporting this to the maintainers of 
>>> org.apache.catalina.loader.WebappClassLoaderBase
>>> WARNING: Use --illegal-access=warn to enable warnings of further 
>>> illegal reflective access operations
>>> WARNING: All illegal access operations will be denied in a future 
>>> release
>>> WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
>>> application [roller] appears to have started a thread named 
>>> [Log4j2-AsyncAppenderEventDispatcher-1-asyncRoller] but has failed 
>>> to stop it. This is very likely to create a memory leak. Stack trace 
>>> of thread:
>>>  [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
>>>  [email protected]/java.util.concurrent.locks.LockSupport.park(LockSupport.java:194) 
>>>
>>>  [email protected]/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2081) 
>>>
>>>  [email protected]/java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:417) 
>>>
>>>  org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.dispatchAll(AsyncAppenderEventDispatcher.java:71) 
>>>
>>>  org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.run(AsyncAppenderEventDispatcher.java:63) 
>>>
>>> WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
>>> application [roller] appears to have started a thread named 
>>> [HttpClient-1-SelectorManager] but has failed to stop it. This is 
>>> very likely to create a memory leak. Stack trace of thread:
>>>  [email protected]/sun.nio.ch.EPoll.wait(Native Method)
>>>  [email protected]/sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:120) 
>>>
>>>  [email protected]/sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:124) 
>>>
>>>  [email protected]/sun.nio.ch.SelectorImpl.select(SelectorImpl.java:136) 
>>>
>>>  platform/[email protected]/jdk.internal.net.http.HttpClientImpl$SelectorManager.run(HttpClientImpl.java:867) 
>>>
>>> ERROR 2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web 
>>> application [roller] created a ThreadLocal with key of type 
>>> [java.lang.ThreadLocal] (value [java.lang.ThreadLocal@1135abda]) and 
>>> a value of type 
>>> [org.eclipse.persistence.internal.jpa.EntityManagerImpl] (value 
>>> [org.eclipse.persistence.internal.jpa.EntityManagerImpl@74502929]) 
>>> but failed to remove it when the web application was stopped. 
>>> Threads are going to be renewed over time to try and avoid a 
>>> probable memory leak.
>>> INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Stopping 
>>> ProtocolHandler ["http-nio-8080"]
>>> INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Stopping 
>>> ProtocolHandler ["ajp-nio-127.0.0.1-8009"]
>>> INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Destroying 
>>> ProtocolHandler ["http-nio-8080"]
>>> INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Destroying 
>>> ProtocolHandler ["ajp-nio-127.0.0.1-8009"]
>>>
>>> On 18/12/2021 20:48, Dave wrote:
>>>> I propose that we release Roller v6.1.0 based on the code that is 
>>>> currently
>>>> in the master branch. I have prepared a release candidate and some 
>>>> release
>>>> notes, below.
>>>>
>>>> Please vote in the next 72 hours to approve this release.
>>>> +1 to release
>>>> -1 not to release (with reasons)
>>>>
>>>> Thanks to Michael Bien for all his work since the 6.0.1 release on bug
>>>> fixes, general improvements and dependency updates like the 
>>>> important one
>>>> he made today to upgrade Log4j to 2.17.0.
>>>>
>>>> The release candidate files are here:
>>>> https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/
>>>>
>>>> Release notes
>>>>
>>>> This is a bug fix and dependency update release that includes all 
>>>> changes
>>>> made to the master branch since August 16, 2021. It also includes 
>>>> the new
>>>> patched Log4j release. This release should be a drop-in replacement 
>>>> of the
>>>> previous v6.0.2 release.
>>>>
>>>> Here is a summary of the changes.
>>>>
>>>> All Pull Requests that were merged since August 16, 2021
>>>> https://github.com/apache/roller/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged 
>>>>
>>>>
>>>> Bug resolved since August 16, 2021
>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ROL%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolutiondate%20%3E%20%272019%2F12%2F27%27 
>>>>
>>>>
>>>> And there is one database change: in the weblog table, the column 
>>>> blacklist
>>>> has been renamed to bannedwordslist.
>>>>
>>