Re: Upgrade to latest struts

Michael Bien <[email protected]> Fri, 6 Oct 2023 12:41:34 +0200
Newsgroups gmane.comp.java.roller.devel
Message-ID <[email protected]>
Hi Greg,

you could open a PR which will let tests run against it. This produces a 
dev build too for manual testing.

on first glance:

app/tools/roller.xml is probably not intended on the commit

there are also a lot of whitespace changes in the commit. PR diffs can 
filter some of them out, but automated formatting changes in the javadoc 
for example should be avoided to make diffs smaller. Its probably an IDE 
setting somewhere. It is often better to separate cleanup and actual 
changes.

-mbien

On 06.10.23 11:51, Greg Huber wrote:
> Struts devs have updated the 4.0.x struts2-bootstrap-plugin to work on 
> the latest version of struts
>
> dependency>
> <groupId>com.jgeppert.struts2.bootstrap</groupId>
> <artifactId>struts2-bootstrap-plugin</artifactId>
>             <version>4.0.2-SNAPSHOT</version>
> </dependency>
>
> It will be maintained also going forward (hopefully).
>
>
> Here is an upgraded version that I have done, only a few changes are 
> needed.
>
> https://github.com/gregh3269/roller/tree/Upgrade_to_Struts-6.3.0.1
>
>
> I have tested it and looks the same.  Can you have a look?  Need to 
> get off the 2.5.x branch.
>
>
> Cheers Greg
>
>