Re: [PR] Dependency updates and some compiler warning cleanu p in tests [roller]

mbien (via GitHub) <[email protected]> Sun, 04 Feb 2024 04:48:43 -0000

Newsgroups	gmane.comp.java.roller.devel
Message-ID	<PR_kwDOAAMmdM5l752U-e7f584b4-2246-4b67-9741-5fc2cbeef816@gitbox.apache.org>

mbien commented on code in PR #135:
URL: https://github.com/apache/roller/pull/135#discussion_r1477177726


##########
.github/workflows/main.yml:
##########
@@ -59,7 +59,7 @@ jobs:
       - name: Run Integration Tests
         run: |
           cd it-selenium
-          mvn -V -ntp -Dwebdriver.gecko.driver=$GECKOWEBDRIVER/geckodriver install
+          mvn -V -ntp install

Review Comment:
   I think the newer version of the firefox selenium plugin is managing the geckodriver download automatically



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]