Scarab commit: svn commit: r10136 - trunk/src/java/org/tigris/scarab/om/AbstractScarabModule.java

Author: pledbrook
Date: 2006-06-02 08:24:07-0700
New Revision: 10136

Modified:
   trunk/src/java/org/tigris/scarab/om/AbstractScarabModule.java

Log:
Removed a Criteria.setDistinct() call from AbstractScarabModule because
both PostgreSQL and Oracle were unhappy with it. It didn't seem to be
doing anything anyway because all the records returned by the query were
unique.

The specific problem is that PostgreSQL and Oracle require that any
ORDER BY column is included as a SELECT column when the DISTINCT option
is used.


Modified: trunk/src/java/org/tigris/scarab/om/AbstractScarabModule.java
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/java/org/tigris/scarab/om/AbstractScarabModule.java?view=diff&rev=10136&p1=trunk/src/java/org/tigris/scarab/om/AbstractScarabModule.java&p2=trunk/src/java/org/tigris/scarab/om/AbstractScarabModule.java&r1=10135&r2=10136
==============================================================================
--- trunk/src/java/org/tigris/scarab/om/AbstractScarabModule.java	(original)
+++ trunk/src/java/org/tigris/scarab/om/AbstractScarabModule.java	2006-06-02 08:24:07-0700
@@ -1135,10 +1135,9 @@
         crit.add(AttributePeer.DELETED, false);
         crit.add(RModuleAttributePeer.ACTIVE, true);
         //crit.addAscendingOrderByColumn(
-        //       RModuleAttributePeer.DISPLAY_VALUE);        
+        //       RModuleAttributePeer.DISPLAY_VALUE);
         crit.addAscendingOrderByColumn(
                 RModuleAttributePeer.PREFERRED_ORDER);
-        crit.setDistinct();
         List result = AttributePeer.doSelect(crit);
         return result;
     }