Author: jhoech
Date: 2008-11-26 00:48:33-0800
New Revision: 10649
Modified:
trunk/src/java/org/tigris/scarab/actions/admin/GlobalAttributeEdit.java
trunk/src/java/org/tigris/scarab/om/MITList.java
trunk/src/java/org/tigris/scarab/om/ParentChildAttributeOption.java
trunk/src/java/org/tigris/scarab/pipeline/AnonymousLoginValve.java
trunk/src/java/org/tigris/scarab/xmlrpc/ScarabUpdateHelper.java
Log:
ADD - some comments added from my investigation approaches
Modified: trunk/src/java/org/tigris/scarab/actions/admin/GlobalAttributeEdit.java
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/java/org/tigris/scarab/actions/admin/GlobalAttributeEdit.java?view=diff&rev=10649&p1=trunk/src/java/org/tigris/scarab/actions/admin/GlobalAttributeEdit.java&p2=trunk/src/java/org/tigris/scarab/actions/admin/GlobalAttributeEdit.java&r1=10648&r2=10649
==============================================================================
--- trunk/src/java/org/tigris/scarab/actions/admin/GlobalAttributeEdit.java (original)
+++ trunk/src/java/org/tigris/scarab/actions/admin/GlobalAttributeEdit.java 2008-11-26 00:48:33-0800
@@ -210,7 +210,7 @@
/**
* Used on AttributeEdit.vm to change the name of an existing
- * AttributeOption or add a new one if the name doesn't already exist.
+ * AttributeOption or create a new one if the name doesn't already exist.
*/
public synchronized boolean
doSaveoptions(RunData data, TemplateContext context)
@@ -356,6 +356,8 @@
}
}
}
+ // all existing attribute options are checked
+
if (somethingSaved)
{
scarabR.setConfirmMessage(l10n.get(DEFAULT_MSG));
Modified: trunk/src/java/org/tigris/scarab/om/MITList.java
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/java/org/tigris/scarab/om/MITList.java?view=diff&rev=10649&p1=trunk/src/java/org/tigris/scarab/om/MITList.java&p2=trunk/src/java/org/tigris/scarab/om/MITList.java&r1=10648&r2=10649
==============================================================================
--- trunk/src/java/org/tigris/scarab/om/MITList.java (original)
+++ trunk/src/java/org/tigris/scarab/om/MITList.java 2008-11-26 00:48:33-0800
@@ -472,6 +472,9 @@
/**
* Checks all items to see if they contain the attribute.
*
+ * An attribute is called a common attribute, if it is attached to all issue types
+ * in one module.
+ *
* @param attribute an <code>Attribute</code> value
* @return a <code>boolean</code> value
*/
@@ -645,7 +648,14 @@
}
return permissions;
}
-
+
+ /**
+ * fetches all saved rmuas from the database for this list
+ * @return
+ * @throws TorqueException
+ * @throws DataSetException
+ * @throws TurbineSecurityException
+ */
public List getAllRModuleUserAttributes()
throws TorqueException, DataSetException, TurbineSecurityException
{
@@ -653,6 +663,15 @@
return rmuas;
}
+ /**
+ * selects all common rmuas for this list,
+ * if there are no saved rmuas in the database they will be created
+ *
+ * @return
+ * @throws TorqueException
+ * @throws DataSetException
+ * @throws TurbineSecurityException
+ */
public List getCommonRModuleUserAttributes()
throws TorqueException, DataSetException, TurbineSecurityException
{
Modified: trunk/src/java/org/tigris/scarab/om/ParentChildAttributeOption.java
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/java/org/tigris/scarab/om/ParentChildAttributeOption.java?view=diff&rev=10649&p1=trunk/src/java/org/tigris/scarab/om/ParentChildAttributeOption.java&p2=trunk/src/java/org/tigris/scarab/om/ParentChildAttributeOption.java&r1=10648&r2=10649
==============================================================================
--- trunk/src/java/org/tigris/scarab/om/ParentChildAttributeOption.java (original)
+++ trunk/src/java/org/tigris/scarab/om/ParentChildAttributeOption.java 2008-11-26 00:48:33-0800
@@ -265,7 +265,12 @@
{
return getParentId() + ":" + getOptionId() + " -> " + getName();
}
-
+
+ /**
+ * saves the according attribute option and option-option relation
+ * @throws TorqueException
+ * @throws ScarabException
+ */
public void save()
throws TorqueException, ScarabException
{
Modified: trunk/src/java/org/tigris/scarab/pipeline/AnonymousLoginValve.java
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/java/org/tigris/scarab/pipeline/AnonymousLoginValve.java?view=diff&rev=10649&p1=trunk/src/java/org/tigris/scarab/pipeline/AnonymousLoginValve.java&p2=trunk/src/java/org/tigris/scarab/pipeline/AnonymousLoginValve.java&r1=10648&r2=10649
==============================================================================
--- trunk/src/java/org/tigris/scarab/pipeline/AnonymousLoginValve.java (original)
+++ trunk/src/java/org/tigris/scarab/pipeline/AnonymousLoginValve.java 2008-11-26 00:48:33-0800
@@ -43,8 +43,9 @@
}
}
- /*
+ /**
* Invoked by the Turbine's pipeline, as defined in scarab-pipeline.xml
+ * If anonymous access is allowed and current user is null the anomynous user is logged in.
* @see org.apache.turbine.pipeline.AbstractValve#invoke(org.apache.turbine.RunData, org.apache.turbine.ValveContext)
*/
public void invoke(RunData data, ValveContext context) throws IOException, TurbineException
Modified: trunk/src/java/org/tigris/scarab/xmlrpc/ScarabUpdateHelper.java
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/java/org/tigris/scarab/xmlrpc/ScarabUpdateHelper.java?view=diff&rev=10649&p1=trunk/src/java/org/tigris/scarab/xmlrpc/ScarabUpdateHelper.java&p2=trunk/src/java/org/tigris/scarab/xmlrpc/ScarabUpdateHelper.java&r1=10648&r2=10649
==============================================================================
--- trunk/src/java/org/tigris/scarab/xmlrpc/ScarabUpdateHelper.java (original)
+++ trunk/src/java/org/tigris/scarab/xmlrpc/ScarabUpdateHelper.java 2008-11-26 00:48:33-0800
@@ -146,7 +146,7 @@
}
/**
- * Remove option from global attribute
+ * Remove option from global attribute and from all modules and issue types.
*
* @param attribute
* @param optionName
@@ -499,7 +499,7 @@
/**
* Handle the the setting, clearing of the deleted flag. If the record does
* not exist, it is created.
- *
+ * Weight is set to value of preferred order.
* @param attribute
* @param optionName
* @param deleted
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.