Scarab commit: svn commit: r10834 - trunk/src/webapp: WEB-INF/templates/macros WEB-INF/templates/viewIssue scripts skins

Author: dabbous
Date: 2009-07-25 09:58:00-0700
New Revision: 10834

Modified:
   trunk/src/webapp/WEB-INF/templates/macros/GlobalMacros.vm
   trunk/src/webapp/WEB-INF/templates/viewIssue/ViewIssueBody.vm
   trunk/src/webapp/scripts/guiUtils.js
   trunk/src/webapp/skins/classic.css

Log:
cosmethic/minor en passant (no issue assigned)
- removed unnecessary style definitions in velocity macros.
- a little bit of cleaning up attribute placements in the issue editor
- removed some warnings about non inititlized variables in javascript (for IE6)
i dont think this is worth an issue ;-)

Modified: trunk/src/webapp/WEB-INF/templates/macros/GlobalMacros.vm
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/webapp/WEB-INF/templates/macros/GlobalMacros.vm?view=diff&pathrev=10834&r1=10833&r2=10834
==============================================================================
--- trunk/src/webapp/WEB-INF/templates/macros/GlobalMacros.vm	(original)
+++ trunk/src/webapp/WEB-INF/templates/macros/GlobalMacros.vm	2009-07-25 09:58:00-0700
@@ -1249,7 +1249,7 @@
                 #if ($linecount > 0 && $index > 6)
                     #set ($isHidden =  !( $currentIssue.isRequiredAttributeFor($att, $user) || $rma.Visible ) )
                     <span id="${displayValue}:Container" #if ($isHidden) style="display:none;" #else style="display:inline;" #end>
-                    <span class="displayValue" style="white-space:nowrap;display:inline;margin-left:0px; margin-right:0px;width:95%;">#drawRequiredMarkupAsNeeded($user $currentIssue $att)$displayValue</span>
+                    <span class="displayValue" style="white-space:nowrap;display:inline;width:95%;">#drawRequiredMarkupAsNeeded($user $currentIssue $att)$displayValue</span>
                 #else
                     #if ($linecount > 0)
                       </td>

Modified: trunk/src/webapp/WEB-INF/templates/viewIssue/ViewIssueBody.vm
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/webapp/WEB-INF/templates/viewIssue/ViewIssueBody.vm?view=diff&pathrev=10834&r1=10833&r2=10834
==============================================================================
--- trunk/src/webapp/WEB-INF/templates/viewIssue/ViewIssueBody.vm	(original)
+++ trunk/src/webapp/WEB-INF/templates/viewIssue/ViewIssueBody.vm	2009-07-25 09:58:00-0700
@@ -150,7 +150,7 @@
           #end
     #end
     <span>
-    <select name="add_watcher" style="position:relative; top:-1px;">
+    <select id="add_watcher" name="add_watcher" style="position:relative; top:-1px;">
       ##if ( $myselfInList == true )
        <option value="" #selected(true) >$l10n.Assign ...</option>
       ##end

Modified: trunk/src/webapp/scripts/guiUtils.js
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/webapp/scripts/guiUtils.js?view=diff&pathrev=10834&r1=10833&r2=10834
==============================================================================
--- trunk/src/webapp/scripts/guiUtils.js	(original)
+++ trunk/src/webapp/scripts/guiUtils.js	2009-07-25 09:58:00-0700
@@ -28,6 +28,7 @@
   	var els = node.getElementsByTagName(tag);
   	var elsLen = els.length;
   	var pattern = new RegExp("(^|\\s)"+searchClass+"(\\s|$)");
+  	var i,j;
   	for (i = 0, j = 0; i < elsLen; i++) {
   		if ( pattern.test(els[i].className) ) {
   			classElements[j] = els[i];
@@ -54,6 +55,7 @@
   	}
   	var buttons = getElementsByClass(clazz);
   	/* loop through all buttons and attach a child div */
+  	var i;
   	for (i=0; i < buttons.length; i++) {
   		var div = document.createElement("div");
   		div.className = clazz+"Ending";

Modified: trunk/src/webapp/skins/classic.css
Url: http://scarab.tigris.org/source/browse/scarab/trunk/src/webapp/skins/classic.css?view=diff&pathrev=10834&r1=10833&r2=10834
==============================================================================
--- trunk/src/webapp/skins/classic.css	(original)
+++ trunk/src/webapp/skins/classic.css	2009-07-25 09:58:00-0700
@@ -323,6 +323,7 @@
 	font-family:Verdana,Helvetica,Arial,sans-serif;
 	font-size:1em;
 	font-weight:bold;
+	margin-left:15px;
 }

------------------------------------------------------
http://scarab.tigris.org/ds/viewMessage.do?dsForumId=3577&dsMessageId=2375555