Re: Scarab commit: svn commit: r10585 - trunk/src: conf/classes conf/conf java/org/tigris/scarab/actions java/org/tigris/scarab/om java/org/tigris/scarab/tools java/org/tigris/scarab/tools/localization java/org/tigris/scarab/util/word java/org/tigris/scarab/xmlrpc test/org/tigris/scarab/util/word

On Thu, 22 May 2008 21:01:42 +0000, ronvoe122 wrote:

> Author: ronvoe122
> Date: 2008-05-22 14:01:42-0700
> New Revision: 10585
> 
> Modified:
>    ...
>    trunk/src/java/org/tigris/scarab/util/word/IssueSearchFactory.java
>    ...
> 
> Log:
> SCB2544: removed the maximum limit for concurrent IssueSearch-instances
> in IssueSearchFactory completely. It doesn't make a lot of sense
> anymore: The initial reason for the limit was to prevent IssueSearch
> from allocating all available DB-connections. The DB-connection is no
> more allocated and held over multiple method calls (with the risk of
> keeping the connection forever, if something goes wrong). The DB-queries
> are no more executed by IssueSearch, but by instances of QueryResult
> which have a different live cycle the IssueSearch-instances. Scarab is
> not of much use, if the Issue-search doesn't work. (Even entering an
> Issue fails, because duplicate-detection relies on the Issue-search.


Why not remove IssueSearchFactory completely?
One less class is a good thing right?

~mck


-- 
"I don't think they could put him in a mental hospital.  On the other 
hand,
if he were already in, I don't think they'd let him out."
| www.semb.wever.org | www.sesat.no | www.sesam.no |