Re: Unified appearance of comments and history

Mick Semb Wever <[email protected]> Fri, 4 Jul 2008 16:30:41 +0000 (UTC)
Newsgroups gmane.comp.java.scarab.devel
Message-ID <[email protected]>
The commit looks good. thanks for putting the work in ronny.

A couple of comments:

 a) it's a little unclear whether the first column is new value or 
original value. Is it from->to or to<-from ?

 b) the two columns are often of different widths making the page a 
little awkward at times: you don't immediately spot the from -> to layout 
of the page.

 c) in each changeset header can the date come first?
to me this makes more sense as the rows are sorted by date and i'm used 
to reading lists with the "item number" being first.

 d) on the comments tab, the comments are still very jammed up tight. 
That is they have lost their margin/padding. take a look at 
http://sesat.no/scarab/issues/curmodule/10001/tqk/0/curadminmenu/1/template/ViewIssue.vm/id/SKER3540/eventsubmit_dosetissueview/foo/action/ViewIssue/tab/3
compared to
http://www.solitone.org/scarab/issues/curmodule/100/tqk/0/template/ViewIssue.vm/id/SCB2546/eventsubmit_dosetissueview/foo/action/ViewIssue/tab/3

~mck

-- 
Daddy, why doesn't this magnet pick up this floppy disk?
| www.semb.wever.org | www.sesat.no | www.sesam.no |