Issue #SCB1381 In progress
Ronny Voelker <[email protected]>
| Newsgroups | gmane.comp.java.scarab.issues |
|---|---|
| Message-ID | <[email protected]> |
Activity report on *Enhancement SCB1381 - Scarab summary page* Scarab Link: http://www.solitone.org/scarab/issues/id/SCB1381 Module: Scarab Activity generated by Ronny Voelker ([email protected]) at 02/14/2008 00:10 *Reasons for the changes* - in progress. *Attribute changes* - "Target milestone" changed from "1.0" to "0.22" - "Status" changed from "New" to "In progress" - "Priority" changed from "2-High" to "3-Normal" ------------------------------------------------------------------------------- *Comments* - By Ronny Voelker - 02/14/2008 00:10 --- "The patch looks like a good start. Some remarks: You should create a new method in ScarabModule which returns only the not-deleted module-level reports and use this method in ModifyModule.vm. (We should try to keep the domain logic in the java code. Scarabs velocity templates are already way to complicated.) I would make no distinction between a deleted report as a non-existing report. getDefaultReport should just return null for a deleted report. Reports can be expensive in terms of performance. The summary-report will be executed quite often. So it is possible to bring a Scarab-instance down by setting up the 'right' report. Probably we have to think about some kind of caching before releasing this feature. "