Issue #SCB2535

Activity report on

  *Defect SCB2535 - notification screen fails from auto created users*
 
  Scarab Link: http://www.solitone.org/scarab/issues/id/SCB2535
  Module: Scarab


  Activity generated by  Michael Semb Wever ([email protected])  at 05/05/2008 15:35



  *Comments*
  - By Michael Semb Wever - 05/05/2008 15:35 ---
  "i fixed the problem with notifications not being sent by rewriting NotificationStatus.compareTo to detect null ActivityType and put them at the end/bottom of the sort.
That is:

Index: src/java/org/tigris/scarab/om/NotificationStatus.java
===================================================================
--- src/java/org/tigris/scarab/om/NotificationStatus.java	(revision 10546)
+++ src/java/org/tigris/scarab/om/NotificationStatus.java	(working copy)
@@ -250,6 +250,17 @@
             rdo = user1.compareTo(user2);
             if (0 == rdo)
             {
+                if(not1.getActivityType() == not2.getActivityType())
+                {
+                    return 0;
+                }else if(null == not1.getActivityType())
+                {
+                    return 1;
+                }else if(null == not2.getActivityType())
+                {
+                    return -1;
+                }
+                

Do you object if i commit this?
It might leave bad notifications in SCARAB_NOTIFICATION_STATUS but at least leaves them at the end and let's all other notifications through!"