Re: SignalHook questions

"Scott G. Miller" <[email protected]> Wed, 22 Feb 2006 07:28:39 -0600
Newsgroups gmane.comp.java.sisc.devel
Message-ID <[email protected]>
On Wed, Feb 22, 2006 at 07:23:13AM +0000, Matthias Radestock wrote:
> 
> I have a few questions regarding sisc.util.SignalHook.
> 
> * why does addHandler() call itself recursively?

The first pass through makes sure there is an entry in the map with an
associated list, and the second adds to that list.  Its simpler
than a loop or duplicated code.

> 
> * shouldn't the code that accesses the handler table be synchronized?
> 
Yes.  Will fix.

> Also, I believe this code is suffering from the same problem as
> described in bug 1435707.

Yes, it does, ever since the recent change to not using app names.
In SignalHook's case, its probably sufficient to change it to store
the AppContext in the table, rather than a DynamicEnvironment.

        Scott


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642