Re: [skinlf-dev] Follow-up on laf-plugin proposal

Frédéric Lavigne <[email protected]> Fri, 17 Feb 2006 12:14:43 +0100
Newsgroups gmane.comp.java.skinlf.devel
Message-ID <[email protected]>
Hi Kirill,

I worked on it but did not commit the code yet. I copied the code  
from the LiquidLnf.

I have the following questions though regarding the integration:

* about initialize() and reset(), should I call both of them in  
LookAndFeel#initialize or only the first?

* what is the recommended approach? one static PluginManager (as done  
in LiquidLnf) or one PluginManager instance as member of the  
LookAndFeel subclass?

* why separate getFonts() and getDefaults() methods?

* plugin.getDefaults takes as parameter a themeInfo so the plugin  
developer can specify different "defaults" based on the current  
theme. Why getFonts and even getUIDelegates do not follow the same  
scheme?

* I had to copy a bunch of code from the LiquidLnf and did not have  
to make any changes to the copied code. Maybe the PluginManager could  
provide more helper methods like "initializeAvailablePlugins()",  
"resetAvailablePlugins()", "populateDefaultsFromPlugins(UIDefaults  
defaults)"... I mean all kinds of methods which would make the  
integration even easier. With this method I would just declare a  
PluginManager then call one of its method in my LookAndFeel  
initialize, initComponentDefaults, initClassDefaults, ... I checked  
the SquarenessLookAndFeel and it also duplicates this code.

regards,
-fred

On Feb 16, 2006, at 10:29 PM, Kirill Grouchnikov wrote:

> Frederic,
>
> We have spoken about two months ago on possible adoption of laf- 
> plugin [1] in this project. Has this ever come to the list of  
> things to-do or should i drop this subject entirely?
>
> Thanks
> Kirill
>
> [1] https://laf-plugin.dev.java.net
>
>
> What are the most popular cars? Find out at Yahoo! Autos