Re: runshell/runjava lifecycle

Your points are quite valid and the reason for those is that runShell is
a legacy component that has been replaced by shellScripting components
and it should be removed or relocated to a legacy package at some point.
Therefore it has not been properly updated and/or maintained.


Julio G



-----Original Message-----
From: smartfrog-developer-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
[mailto:smartfrog-developer-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of
Steve Loughran
Sent: 21 September 2006 12:00
To: smartfrog-developer
Subject: [Smartfrog-developer] runshell/runjava lifecycle

One thing I am looking at is the RunShell component, that RunJava is 
based on. This has a couple of interesting features

1. it has its own attributes, "shouldDetach" "shouldTerminate", and 
"terminateOnFailure".  We could also support the new 'standard' 
sfShouldDetach,  sfShouldTerminate  and sfShouldTerminateQuietly options

2. it starts the thread under sfDeploy() and not sfStart(). Surely this 
is wrong? It should do its work under sfStart()? in sfStart(), runshell 
starts running the commands on the command list, but if you are using 
the component just to execute a native or java program with no commands,

the execution should be delayed until sfStart(), as that is when you 
know everything else is set up right.

We could fix #2 without breaking things by having a flag saying when to 
start the worker thread.


for now, I'm leaving it alone but filing a bugrep.

-steve

------------------------------------------------------------------------
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDE
V
_______________________________________________
Smartfrog-developer mailing list
Smartfrog-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/smartfrog-developer

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV