Re: wrong definition of ToggleToFalseWorkflow ?

Steve Loughran <[email protected]> Mon, 25 Jun 2007 12:17:27 +0100
Newsgroups gmane.comp.java.smartfrog.devel
Message-ID <[email protected]>
Andreas Unterkircher wrote:
> Hello,
> 
> Looking at the tests for the Sequence component I see in the file
> 
> ./testharness/testcases/org/smartfrog/test/system/workflow/sequence/ 
> testSequence.sf
> 
> [...]
> 
> sfConfig extends TestBlock {
> 
>      action extends Sequence {
>        //set sfConfig:value=false
>         toggle1 extends ToggleToFalseWorkflow {
>            target LAZY PARENT:PARENT;
>         }
> 
> [...]
> 
> ToggleToFalseWorkflow is defined in ./testharness/testcases/org/ 
> smartfrog/test/system/assertions/components.sf:
> 
> [...]
> 
> ToggleToFalseWorkflow extends BooleanTrue {
>    sfShouldTerminate true;
> }
> 
> I think with this definition it does not set value=false in its  
> target attribute. Shouldn't the definition be
> 
> ToggleToFalseWorkflow extends ToggleToFalse {
>    sfShouldTerminate true;
> }
> 

Looks like it. I will make the change, and see what happens .

Thank you for your code review!

-steve

-- 
-----------------------
Hewlett-Packard Limited
Registered Office: Cain Road, Bracknell, Berks RG12 1HN
Registered No: 690597 England

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/