LoggerStore

Hi,

I finally had a chance to look at the loggerstore component. Looks great. 

I change a few things - most of them cosmetic and should no effect. The only 
significant change I made was moving the constants for the logger type to the 
configurator as thats the only place they are actually used.

Other things to think about;

LoggerStore vs LoggerStoreFactory Responsibilities
--------------------------------------------------

It may be better to push all the construction code for input to LoggerStores 
into LoggerStoreFactory. In some cases the LoggerStoreFactory passes in an 
InputStream into the LoggerStore implementation and the LoggerStore will use 
that to build the properties/XML. 

A better idea to move the construction of properties/XML into 
LoggerStoreFactory. That way it becomes easier to change how this is loaded 
in the future without changing the LoggerStore implementation. ie We could 
load the properties/XML from ContextClassLoader or perhaps classloader passed 
into factory. 

If we did all the construction in the LoggerStoreFactory then we would just 
need to change that rather than having to change both the LoggerStore and the 
coresponding factory. It also makes testing the LoggerStore much more easier.

Testing Output
--------------

Currently the tests just do some configuration and assume it all works. What 
we should really do is be testing the output produced by the configured 
loggers matches what we think it should be. 

LogKit1.2/Next Log4j
--------------------

I think we are using unreleased features from both of these toolkits. We 
should push to get them released as soon as possible.

Thoughts?

-- 
Cheers,

Peter Donald
-------------------------------------------------------
To fight and conquer in all your battles is not supreme 
excellence; supreme excellence consists in breaking the 
enemy's resistance without fighting. - Sun Tzu, 300 B.C.
-------------------------------------------------------



-------------------------------------------------------
Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara
The only event dedicated to issues related to Linux enterprise solutions
www.enterpriselinuxforum.com