Re: LoggerStore

On Tue, 27 May 2003 12:12 am, Mauro Talevi wrote:
> A couple of minor comments on the reworking:
> - Even though atm only Log4J has more than one configuration type, I had
> envisaged that eg JDK14 might have an XML configuration soon
> (and one could  actually write a configuration parser if one wanted).
> So, since the types XML and PROPERTIES are quite generic, how about
> moving them to the LoggerStoreFactory interface?

I was actually thinking of going the opposite way. ie Break the 
Log4JLoggerStoreFactory into Log4JXMLLoggerStoreFactory and 
Log4JPropertiesLoggerStoreFactory. 

That way each factory has a unique input type

> - Log4J Element configuration relies on the EntityResolver for correct
> configuration.  

To be honest I have never seen this need except when parsing out the ELement. 
When the element is already parsed I haven't needed the EntityResolver as 
entitys are resolved at parse time. Could you give me an example where it is 
needed when you already have the ELment object?

> Also:
> - I've replace HierarchyUtil with the LogKitLoggerManager for the
> LogTargets cache.  I've posted the patch to the avalon list for the
> LoggerManager.  Until then the build relies on a snapshot version of
> excalibur-logger with the patch applied.

I had a look and it seems that you retrieve the logTargets from the Excalibur 
LoggerManager and then close them. Would it not be better to add a 
Disposable.dispose() method to Excalibur LoggerManager that automatically 
cleaned up itself rather than manually closing them?

-- 
Cheers,

Peter Donald
*----------------------------------------------------*
| We must become the change we want to see. - Gandhi |
*----------------------------------------------------*



-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge