Re: LoggerStore

On Wed, 28 May 2003 09:29 am, Mauro Talevi wrote:
> Peter Donald wrote:
> > On Tue, 27 May 2003 06:24 pm, Peter Donald wrote:
> >>Two things remain to do before we do a release;
> >>
> >>* Determine what we are going to do with "type". Do we make a separate
> >>LoggerStoreFactory for each type (XML vs properties).
>
> done - I've refactored to remove type and split the Log4J factory.

great!

> done - I've refactored the test cases to have an abstract base class,
> and concrete ones for LoggerStore, LoggerStoreFactory and Configurator.
> There is still a problem as it tries to look for the
> Log4jLoggerStoreFactory I've removed ... could you have a look?
> I'm obviously missing something ...

Okay - it looks like you just needed to update the 
src/test/META-INF/spice/loggerstore.properties file to point to new factory 
and it works. I have just done this and it all looks good.

BTW run "maven site:generate" and have a look at the clover report .. we 
missed a few cases in the unit tests ... wanna volunteer ? :)

-- 
Cheers,

Peter Donald
*------------------------------------------------------*
| "The whole problem with the world is that fools and  |
| fanatics are always so certain of themselves, but    |
| wiser people so full of doubts." - Bertrand Russell  |
*------------------------------------------------------*



-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge