Re: Experimental Picoification of CommonsThreadPool

Hiya,

From: "Paul Hammant" <[email protected]>
> Mauro and I and (plug) GeekNight(TM), decided to have some fun with the
> CommonsThreadPool impl of ThreadPool in the Spice codebase. We've made
> only new classes, so this is easy to delete. We'd love to discuss first...

I finally got around to looking at it - yea! The first thing I started to do
was refactor it slightly. The way I did it was to have both
AvalonCommonsThreadPool and PicoCommonsThreadPool extend a common base class
CommonsThreadPool. This was mainly to just get rid of the duplication of
code across different components. Could you check the code and make sure it
still all works properly? I also made some classes package access and moved
stuff around a bit.

Anyways I definetly like this approach for enabling components to multiple
component systems. What do you think ? The only real change I would make is
that I would move the ThreadPoolMonitor into the impl package as it is only
used by implementations - thoughts?

> We cloned the test-case to prove it all worked. It didn't.

I haven't even checked if the code compiles - let alone passes unit tests so
your forgiven this time ... as long as you add documentation to the monitors
;)

> Then we found
> that the TestCase we cloned from didn't work ;-) Maurio thinks is my
> Windoze/JDK1.4.2-beta machine ;-)

Ug ... dont have a win box to track it down on atm. Maybe in at a clients
office on wend though ;)

Cheers,

Peter Donald