Re: Experimental Picoification of CommonsThreadPool

peter-4lf8KW9E9MLMqX/[email protected] wrote:

> I finally got around to looking at it - yea! The first thing I started to do
> was refactor it slightly. The way I did it was to have both
> AvalonCommonsThreadPool and PicoCommonsThreadPool extend a common base class
> CommonsThreadPool. This was mainly to just get rid of the duplication of
> code across different components. Could you check the code and make sure it
> still all works properly? I also made some classes package access and moved
> stuff around a bit.

like refactor (we had held off any refactor of existing code on purpose)
and works fine - except that Pico test case still fails, as expected.

> Anyways I definetly like this approach for enabling components to multiple
> component systems. What do you think ? 

like it :-)

> The only real change I would make is
> that I would move the ThreadPoolMonitor into the impl package as it is only
> used by implementations - thoughts?

yup - implementation proper. moved it.
also renamed ThreadPoolTestCase to AvalonThreadPoolTestCase.

> Ug ... dont have a win box to track it down on atm. Maybe in at a clients
> office on wend though ;)

tested on win xp/jdk1.4.1 and it passes.  perhaps a 1.4.2-beta issue? 
paul, could you try it on 1.4.2-final?

cheers