[Bug 102] traditionnal layout - assert fails on ppc

http://sablevm.org/bugs/show_bug.cgi?id=102

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



------- Additional Comments From [email protected]  2005-02-28 22:55 -------
Simply removing the assertion does not seem to be good idea.  It would lead
to serious memory corruption during GC.  Instead could you please try to run
ie. Eclipse with traditional object layout after doing the following change:

Index: src/libsablevm/system.c
===================================================================
--- src/libsablevm/system.c     (revision 3533)
+++ src/libsablevm/system.c     (working copy)
@@ -492,7 +492,7 @@

   _svmt_word end =
     (class->data.noninterface.next_offset_no_hashcode - _svmf_aligned_size_t
-     (sizeof (_svmt_object_instance))) / SVM_ALIGNMENT;
+     (sizeof (_svmt_object_instance))) / sizeof (void *);
   _svmt_word offsets = 0;
   const size_t head_size =
     _svmf_aligned_size_t (sizeof (_svmt_object_instance));
@@ -501,9 +501,6 @@
   size_t *ref_field_offsets = class->data.noninterface.ref_field_offsets;
   jboolean overflow = JNI_FALSE;

-  /* we're on ia32, so alignment should be the same as ptr size */
-  assert (SVM_ALIGNMENT == sizeof (void *));
-
   if (end > 7)
     {
       overflow = JNI_TRUE;

       overflow = JNI_TRUE;

Please commit it, if it fixes the issue.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the QA contact for the bug, or are watching the QA contact.