Re: function signature "funny"

"Grzegorz B. Prokopski" <[email protected]> Tue, 14 Jun 2005 00:02:38 -0400
Newsgroups gmane.comp.java.vm.sablevm.devel
Organization Debian http://www.debian.org - The Free Operating System
Message-ID <[email protected]>
 On Mon, 2005-13-06 at 10:26 -0400, Etienne Gagnon wrote:
> Hi Peter, David and all,
> 
> SableVM simply implements the published specification.  In
> http://java.sun.com/docs/books/jni/html/functions.html you can read:
> 
>  GetStringUTFChars
> 
>  Prototype const jbyte * GetStringUTFChars(JNIEnv *env, jstring string,
> jboolean *isCopy);
> 
> So, if Sun's "super secret" jni.h is different, I think there's a
> specification bug.  This shows you Sun's arrogance; they don't think
> that fixing specification bugs is important...  I do not look at Sun's

I imagine they didn't have any such picky compiler at that time that
would distinguish between "char" and "signed char".  But yes, have the
specs been actively and openly maintained we could just go and get it
fixed it there right away.

> jni.h file, as Sun claims that any source code in their software
> development kit is confidential intellectual property; I have no wish of
> "stealing" any of their super secret intellectual property.

Of course.  Nobody wants to steal anything.  Our discussion didn't start
with "Hey, Sun has it differently in their jni.h, let's make it the
same", but with "I am getting warnings because of inconsistency in types
used by functions that obviously are meant to operate on the same data".

Personally, I was more interested in GCC vs. C specs aspect here.  That
we should make our JNI interface internally consistent has been obvious
since the beginning.  I envision the next time we get back to this
problem will be when SableVM is tested with TCK and this turns up to be
a compatibility issue ;-p

Anyway, this is fixed in the trunk now.  Let me note that this is not
the first and probably not the last tiny fix we do thanks to GCC4 being
more and more picky (which is a good thing for the most part).

Thanks everyone,

			Grzegorz B. Prokopski
-- 
Grzegorz B. Prokopski           <[email protected]>
SableVM - Free, LGPL'ed Java VM  http://sablevm.org
Why SableVM ?!?                  http://sablevm.org/wiki/Features
Debian GNU/Linux - the Free OS   http://www.debian.org