Re: [sablevm-jchevm] Windows port

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--===============1732100455==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig2006B7DF069C683A0F6F7517"

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig2006B7DF069C683A0F6F7517
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Enrico Migliore wrote:
> I'm figuring the folder layout structure, to put somewhere, please let
> me know if you find it reasonable:
> 
> win32
>   |_____src                (proposal A)
>   |_____include
> 
> 
> arch
>   |_____win32
>                  |______src         (proposal B)
>                  |______include

It is too soon to go this way.  For now, as I said, you should simply go
the #ifdef way.  The problem of a hierarchy, like above, is that it
duplicates much code.  Look at src/libsablevm/system.c.  You'll see that
many, many platforms share the same code.  So, a hierarchy is only
useful if some code has to be distinct for each system.

FYI, I dislike separate include directories, unless there's a good
reason for doing so.  (See src/libsablevm/include : it has a purpose, as
these files are useful to *users* of sablevm).  I also dislike separate
compilation of each .c, as there is no reason for separate compilation
on modern systems (actually, separate compilation can eliminate many
optimization opportunities, and it forces you to export many symbols
that shouldn't be exported, like static functions).  Sorry for my
compiler background showing up...

> For this initial part of the port, I can make a local copy of the files
> that require Windows specific functions, in the folder: "src" and
> "include", and work on them.

Hmmm....  First, you should get a SableVM sandbox, and do regular
check-ins. ;-)   But, first, we need to settle the legal issues.

I'll get in touch with you in private about it.

> As said, before starting the port, I will read over all the threads we
> wrote, read the documentation of SableVM, and make a written proposal to
> the list, in order to have the maximum level of agreement.

Makes sense.

> I already did a quite complex port in the past (FreeDOS's filesystem
> ported to some embedded platforms) and it took me 6 months, to make a
> clean and reliable work.

Great.  I don't expect SableVM's port to be such a difficult task.
Hopefully. :-)

Thanks,

Etienne


-- 
Etienne M. Gagnon, Ph.D.            http://www.info2.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/

--------------enig2006B7DF069C683A0F6F7517
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEPC4jjyrJi4rH84gRAqkkAJoDLeSGHRP/oAB8SVQjFMfKZN/kzwCggPBv
KOcIlyUrPEjsnE2ZTh7e0Ts=
=WlfE
-----END PGP SIGNATURE-----

--------------enig2006B7DF069C683A0F6F7517--


--===============1732100455==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
SableVM-devel mailing list
[email protected]
http://sablevm.org/lists/control/listinfo/sablevm-devel

--===============1732100455==--