Re: wm.log time stamp broken?
Endre Stølsvik <[email protected]> Mon, 3 Apr 2006 10:47:23 +0200 (CEST)
| Newsgroups | gmane.comp.java.webmacro.user |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 31 Mar 2006, Keats Kirsch wrote: | I don't see the cause of this from a quick inspection, however it does appear | that the LogFile.log method is not thread-safe, given Endre's recent | revelation about the SimpleDateFormat. It isn't the nice "ClockThread" that was ripped out? Maybe it was ripped out, but the using code wasn't fixt up? | | Personally, I'd vote for ripping out the WM logging completely and using a | better framework like Log4J. Yes! Clogging, or the new Ceki-driven SLF4J, og just log4j directly. Watch out for the getting of Loggers (static - not on every instance and definately not on every log-line), and always implement the if (log.isDebugEnabled()) "wrapper". The reason for commenting on it, is that I do think I've seen places where this is totally wrong within WM. Endre. ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642