webwork/src/main/webwork/view/jasperreports JasperReportViewServlet.java,1.1,1.2

[email protected] Mon, 15 Jul 2002 06:02:39 -0700
Newsgroups gmane.comp.java.webwork.cvs
Message-ID <[email protected]>
Update of /cvsroot/webwork/webwork/src/main/webwork/view/jasperreports
In directory usw-pr-cvs1:/tmp/cvs-serv7976/src/main/webwork/view/jasperreports

Modified Files:
	JasperReportViewServlet.java 
Log Message:
added correct logging and fixed made url parsing cross platform

Index: JasperReportViewServlet.java
===================================================================
RCS file: /cvsroot/webwork/webwork/src/main/webwork/view/jasperreports/JasperReportViewServlet.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- JasperReportViewServlet.java	15 Jul 2002 04:20:59 -0000	1.1
+++ JasperReportViewServlet.java	15 Jul 2002 13:02:36 -0000	1.2
@@ -17,6 +17,8 @@
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
+import org.apache.log4j.Category;
+
 import webwork.util.ValueStack;
 
 import dori.jasper.engine.JREmptyDataSource;
@@ -29,6 +31,8 @@
 public class JasperReportViewServlet extends HttpServlet
 {
 
+	protected static Category log = Category.getInstance(JasperReportViewServlet.class);
+	
 	private final String SAX_DRIVER = "org.xml.sax.driver";
 	private final String SAX_PARSER = "org.apache.xerces.parsers.SAXParser";
 
@@ -45,7 +49,7 @@
 
 		Map parameters = new HashMap();
 		parameters.put("ReportTitle", "JasperReports Project Description");
-		File directory = new File(systemId.substring(0, systemId.lastIndexOf('/')));
+		File directory = new File(systemId.substring(0, systemId.lastIndexOf(File.separator)));
 		parameters.put("reportDirectory", directory);
 
 		if (System.getProperty(SAX_DRIVER) == null)
@@ -60,7 +64,7 @@
 			pdf = JasperRunManager.runReportToPdf(jasperReport, parameters, stackDataSource);
 		} catch (JRException e)
 		{
-			e.printStackTrace();
+			log.error("Error building report", e);
 			throw new ServletException(e.getMessage());
 		}
 
@@ -75,7 +79,7 @@
 			ouputStream.close();
 		} catch (IOException e)
 		{
-			e.printStackTrace();
+			log.error("Error writing report output", e);
 			throw new ServletException(e.getMessage());
 		}
 




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf