a reminder about patches

Adam Megacz <[email protected]> Sun, 11 Apr 2004 20:28:42 -0700
Newsgroups gmane.comp.java.xwt.core
Organization XWT
Message-ID <[email protected]>
Two reminders:

1. You MUST propose a patch if you want it to get okayed

2. A patch can only be committed by the person who wrote it (this rule
   applies to me too; I cannot/willnot commit patches I did not
   write).

Out of your five gripes, three were already okayed and one
was never proposed (the fifth is a legitimate gripe, although I've had
less than a day to reply since you posted it).

Details follow:

> Sat Apr 10 23:00:38 PDT 2004  [email protected]
>   * freetype.java cleanup (fixes 540)
> Without this, the current nestedvm stuff barfs completely when trying
> to render text.

I just okayed this

> Sun Apr  4 18:51:59 PDT 2004  [email protected]
>   * brian's patch for fullpath backtraces
> Old patch that is still applicable and helps debugging.

This was never proposed.

> Tue Apr  6 15:18:56 PDT 2004  [email protected]
>   * fixes Bug 525 - correct initial frame size
> I just added a test case for this. Charlie's fix works, though it does
> make the window take up the entire screen in situations where it
> shouldn't

http://lists.xwt.org/pipermail/patches/2004-April/000815.html

> Wed Apr  7 19:33:49 PDT 2004  [email protected]
>   UNDO: improved Java2 AWT performance
> This backs out the patch that makes font's virtually unreadable on
> every platform except OSX.

Sorry, you're going to have to find a fix for it other than simply
backing it out.  This is clearly a bug in the Win32 AWT implementation
(if you believe otherwise, please explain).

> Sun Apr 11 14:55:18 PDT 2004  [email protected]
>   * respun fix for 538 to work with adam's latest patches
> Updated fix for 538. Without this, boxes shrink to zero if
> shrink=true, even if they have are filled with an image.

http://lists.xwt.org/pipermail/patches/2004-April/000842.html

  - a