[frameworks/kimageformats] src/imageformats: HEIF: keep reader callback table alive
Daniel Novomeský <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit ad0fb9dde4ffb1977a3ea800d90a26665de687b8 by Daniel Novomeský, on behalf of Kyle Alexander Buan.
Committed on 17/07/2026 at 08:49.
Pushed by novomeskyd into branch 'master'.
HEIF: keep reader callback table alive
libheif retains the heif_reader pointer after
heif_context_read_from_reader returns. The callback table was scoped
to the non-sequential branch and could be destroyed before
tiled image decoding used it from worker threads.
Give the callback table static storage duration.
BUG: 523105
M +2 -1 src/imageformats/heif.cpp
https://invent.kde.org/frameworks/kimageformats/-/commit/ad0fb9dde4ffb1977a3ea800d90a26665de687b8
diff --git a/src/imageformats/heif.cpp b/src/imageformats/heif.cpp
index 436c0843..e5cd3552 100644
--- a/src/imageformats/heif.cpp
+++ b/src/imageformats/heif.cpp
@@ -845,7 +845,8 @@ bool HEIFHandler::ensureDecoder()
buffer = deviceRead(dev, kMaxQVectorSize);
err = heif_context_read_from_memory(ctx, static_cast<const void *>(buffer.constData()), buffer.size(), nullptr);
} else {
- heif_reader reader = create_heif_reader_for_qiodevice();
+ // Must not be destroyed until decoding ends
+ static const heif_reader reader = create_heif_reader_for_qiodevice();
err = heif_context_read_from_reader(ctx, &reader, dev, nullptr);
}
if (err.code) {