[graphics/kuickshow] src: KuickShow: Remove redundant "About" action which now does nothing
Jonathan Marten <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit 8a7cb7033f6b9edb062e2b2d1abd88af15f07a85 by Jonathan Marten.
Committed on 17/07/2026 at 16:38.
Pushed by marten into branch 'master'.
KuickShow: Remove redundant "About" action which now does nothing
M +0 -30 src/kuickshow.cpp
M +0 -4 src/kuickshow.h
https://invent.kde.org/graphics/kuickshow/-/commit/8a7cb7033f6b9edb062e2b2d1abd88af15f07a85
diff --git a/src/kuickshow.cpp b/src/kuickshow.cpp
index 737f004..255afd7 100644
--- a/src/kuickshow.cpp
+++ b/src/kuickshow.cpp
@@ -18,7 +18,6 @@
#include "kuickshow.h"
-#include <KAboutData>
#include <KActionCollection>
#include <KActionMenu>
#include <KConfigGroup>
@@ -55,18 +54,13 @@
#include <QMenu>
#include <QMenuBar>
#include <QMimeDatabase>
-#include <QMouseEvent>
-#include <QSize>
#include <QStandardPaths>
#include <QStatusBar>
-#include <QString>
#include <QScreen>
#include <QTextStream>
#include <QTimer>
#include <QUrl>
-#include <QtGlobal>
-#include "aboutwidget.h"
#include "filecache.h"
#include "filewidget.h"
#include "imagewindow.h"
@@ -134,7 +128,6 @@ KuickShow::KuickShow( const char *objName )
m_slideShowStopped(false)
{
setObjectName(objName);
- aboutWidget = nullptr;
KuickConfig& config = KuickConfig::get();
config.load();
@@ -347,8 +340,6 @@ void KuickShow::initGUI( const QUrl& startDir )
tBar->addSeparator();
tBar->addAction(kuickAction(KuickActionType::OneImageWindow));
tBar->addAction(kuickAction(KuickActionType::PrintImage));
- tBar->addSeparator();
- tBar->addAction(kuickAction(KuickActionType::About));
// Address box in address tool bar
KToolBar *addressToolBar = toolBar( "address_bar" );
@@ -1052,22 +1043,6 @@ void KuickShow::slotConfigClosed()
kuickAction(KuickActionType::Configure)->setEnabled(true);
}
-void KuickShow::about()
-{
- if ( !aboutWidget ) {
- aboutWidget = new AboutWidget(nullptr);
- aboutWidget->setObjectName( QString::fromLatin1( "about" ) );
- }
-
- aboutWidget->adjustSize();
-
- QScreen *screen = windowHandle()->screen();
- const QRect screenRect = screen->geometry();
- aboutWidget->move(screenRect.center().x() - aboutWidget->width() / 2, screenRect.center().y() - aboutWidget->height() / 2);
-
- aboutWidget->show();
-}
-
// ------ sessionmanagement - load / save current directory -----
void KuickShow::readProperties( const KConfigGroup& kc )
{
@@ -1343,10 +1318,6 @@ void KuickShow::setupKuickActions()
i18n("Configure %1...", QGuiApplication::applicationDisplayName()), this);
connect(action, &QAction::triggered, this, &KuickShow::configuration);
- kuickActions[KuickActionType::About] = action = new QAction(QIcon::fromTheme("about"),
- i18n("About KuickShow"), this);
- connect(action, &QAction::triggered, this, &KuickShow::about);
-
kuickActions[KuickActionType::Quit] = KStandardAction::quit(this, &QObject::deleteLater, this);
// application settings
@@ -1403,7 +1374,6 @@ void KuickShow::initializeBrowserActionCollection(KActionCollection* collection)
collection->addAction(QStringLiteral("kuick_slideshow"), kuickAction(KuickActionType::SlideShow));
collection->addAction(QStringLiteral("toggleBrowser"), kuickAction(KuickActionType::ToggleBrowser));
collection->addAction(QStringLiteral("kuick_configure"), kuickAction(KuickActionType::Configure));
- collection->addAction(QStringLiteral("about"), kuickAction(KuickActionType::About));
collection->addAction(QStringLiteral("quit"), kuickAction(KuickActionType::Quit));
collection->addAction(QStringLiteral("kuick_one window"), kuickAction(KuickActionType::OneImageWindow));
collection->addAction(QStringLiteral("kuick_inlinePreview"), fileWidget->action(KDirOperator::ShowPreview));
diff --git a/src/kuickshow.h b/src/kuickshow.h
index 30ce3f9..a61e1ec 100644
--- a/src/kuickshow.h
+++ b/src/kuickshow.h
@@ -33,7 +33,6 @@ class QEvent;
class QLabel;
class QString;
class QUrl;
-class AboutWidget;
class FileWidget;
class ImageWindow;
class KuickConfigDialog;
@@ -53,7 +52,6 @@ enum class KuickActionType : uint
SlideShow,
ToggleBrowser,
Configure,
- About,
Quit,
// application settings
@@ -124,7 +122,6 @@ private Q_SLOTS:
void slotSelected( const KFileItem& );
void dirSelected( const QUrl& );
void configuration();
- void about();
void slotDuplicateWindow(const QUrl &url);
void startSlideShow();
void pauseSlideShow();
@@ -191,7 +188,6 @@ private:
DelayedRepeatEvent *m_delayedRepeatItem;
QTimer *m_slideTimer;
bool m_slideShowStopped;
- QPointer<AboutWidget> aboutWidget;
QLabel* sblblUrlInfo;
QLabel* sblblMetaInfo;