[qt/qt/qtdeclarative]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qt/qtdeclarative Pushed by mirror-service into branch 'dev'. Changed from c94c14262fab4f1ed884669d58c534da8435708f to f943d8e2ee647e335d1745174546594a5d03e2d3 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit 6d6fd1756a5e47689e178689b010109925283f6a by Ulf Hermann (on behalf of Marc Mutz) on 17/07/2026 at 15:39.. DomItem: DRY ownerAs() Extract (Template) Method ownerAs_impl() to factor the repetitive parts of the function out. This also makes the first three branches SCARY, assuming there are, actually, sufficient subclasses of these three types to matter. As a drive-by, remove the two artifical scopes left by two previous commits to avoid re-indentation. This also puts us into better position to do something about C*verity complaining that ownerAs() is throwing bad_variant_access, a known False Positive for the if (holds_alternative<T>) get<T> pattern. Amends 52d61e705ee606f3b673c757bdf253bdf6134a3b (6.2). Pick-to: 6.12 Change-Id: I3a51b022e9b73f5cee374687c5ac053d6c7892a3 Reviewed-by: Ulf Hermann <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/6d6fd1756a5e47689e178689b010109925283f6a Git commit 516c7b850b4042237fb43db8a092108cb258a0d1 by Dilek Akcay on 17/07/2026 at 15:44.. QQmlSortFilterProxyModel: Handle primaryColumn updates without a sourceModel A sorter binding can cause updatePrimaryColumn() to run before the source model has been set. The function then tries to call create_ mapping(), which asserts because no source model is available. Keep the primary column unset until a source model is assigned. The existing setSourceModel() path updates it once the model is available. Change-Id: Ibfb82db7d670eee0da1e5d260c782f4c1c8412c4 Reviewed-by: SanthoshKumar Selvaraj <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/516c7b850b4042237fb43db8a092108cb258a0d1 Git commit d9df0ed93f67a66a18a86f0e4534d40880cf325b by Ulf Hermann on 17/07/2026 at 16:01.. QtQml: Replace QQmlComponent::setData() overload We can't add a first overload to a method commonly used as slot in a signal-slot connection because that breaks source compatibility. Instead, add a method with a new name that only provides the new functionality. Discovered during API review. Pick-to: 6.12 Change-Id: Id630498538ec6fc141eadbb2724c3fa64d7df000 Reviewed-by: Fabian Kosmale <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/d9df0ed93f67a66a18a86f0e4534d40880cf325b Git commit a8266909ff5274e0278d958fb28c37cbf737dfef by Ulf Hermann on 17/07/2026 at 16:01.. QmlPreview: Clarify outerRebuildTarget() return conditions Amends commit ef36cfd4cfd793aa5aab4d5558ca03e8e0f72a74. Pick-to: 6.12 Coverity-Id: 911567 Change-Id: I2f32cb98ec24008734750c74d84575694e18091f Reviewed-by: Fabian Kosmale <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/a8266909ff5274e0278d958fb28c37cbf737dfef Git commit ca7fcace5a740966175218d2dbd24421443a4ce2 by Ulf Hermann on 17/07/2026 at 16:01.. QmlPreview: When stashing external state, consider object's own CU An object may have an own CU that differs from the one that instantiates the object and also from any CUs used for VME metaobjects. This CU may still have constant bindings, though. Amends commit 2bf46dc110c6e78fd0b657196017880151c3ade3. Pick-to: 6.12 Task-number: QTBUG-146122 Change-Id: Ice3d6aa4173914ae9b647d2a4d4cb01755d6f4c6 Reviewed-by: Fabian Kosmale <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/ca7fcace5a740966175218d2dbd24421443a4ce2 Git commit 5289b57272d964f86883ae200fda092eef8e5217 by Ulf Hermann on 17/07/2026 at 16:01.. QmlProfiler: Don't assert when the output file cannot be opened Skip closing the document when the writer was never opened. Trying to write anything to the never-opened writer causes asserts. Pick-to: 6.12 6.11 6.8 Change-Id: Ib1e6fbe8f958c15faa0bbdc8ad949aef7a0bd159 Reviewed-by: Semih Yavuz <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/5289b57272d964f86883ae200fda092eef8e5217 Git commit 4113a2739e5fb852516aa345aa079193c50e8d93 by Ivan Solovev on 17/07/2026 at 16:15.. qmltyperegistrar: fix a typo in Qt::ImhDecima(l)NumbersOnly Pick-to: 6.12 Change-Id: I216b787abe441bc9dde1328479713e70bd1575dc Reviewed-by: Ulf Hermann <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/4113a2739e5fb852516aa345aa079193c50e8d93 Git commit 923641a53155bc1ceafeb9b7f9cd7c10c7125d49 by Kai Uwe Broulik on 17/07/2026 at 16:55.. Accept a proper QKeySequence as shortcut When interfacing with C++, one might pass a proper QKeySequence to a QtQuick Shortcut or QtQuick Controls Action. In order to accept both a StandardKey and a string, the property is defined as QVariant. For anything non-int it would call toString() on the QVariant and pass it to QKeySequence::fromString. However, QVariant has a registered converter to QString in Qt GUI which uses NativeText, i.e. translated and adjusted to the platform. QKeySequence::fromString on the other hand expects PortableText. This mismatch means that assigning a QKeySequence typically worked in an English system but did not when the system was configured for another language (with qttranslations available). Instead, accept a provided QKeySequence and use it as-is. Pick-to: 6.12 6.11 Change-Id: Ib95c8f187fc7ed4f4fc315ee0eae043b632ecf8d Reviewed-by: Mitch Curtis <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/923641a53155bc1ceafeb9b7f9cd7c10c7125d49 Git commit 442b4a463a3351825b62c869be81370ec6c33c98 by Volker Hilsheimer on 18/07/2026 at 02:58.. QQuickHeaderView: don't return default model index from invalid data calls Return the default QVariant instead. Amends 0b607bfe14048e32dd81855e1497dda3465b5183. Discovered while reviewing the code to understand the data/headerData usage of Qt Quick's header views. Pick-to: 6.12 6.11 6.8 Change-Id: Ibd77e12948a78a8140a8088b2c8d0378846e5818 Reviewed-by: SanthoshKumar Selvaraj <[email protected]> Reviewed-by: Dilek Akcay <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/442b4a463a3351825b62c869be81370ec6c33c98 Git commit c57b212de3a8f94e2eef559b37ea5fe5d809a41c by Volker Hilsheimer on 18/07/2026 at 02:58.. QQuickHeaderView: don't emit dataChanged from proxy model's setData The proxy calls setHeaderData() on the source model, which is expected to emit the headerDataChanged signal. We connect to that signal to emit dataChanged, so no need to do it explicitly. Amends 0b607bfe14048e32dd81855e1497dda3465b5183. Pick-to: 6.12 6.11 Change-Id: I8008a84bb276a644319c82daace627309e448144 Reviewed-by: Dilek Akcay <[email protected]> Reviewed-by: SanthoshKumar Selvaraj <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/c57b212de3a8f94e2eef559b37ea5fe5d809a41c Git commit 9f5a1e137fd95c57274e5f316f2334473ca81875 by Qt Submodule Update Bot on 18/07/2026 at 02:59.. Update dependencies on 'dev' in qt/qtdeclarative Change-Id: Ic15cd3a17d9382cd07d66e9321f35247cfc94a22 Reviewed-by: Qt Submodule Update Bot <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/9f5a1e137fd95c57274e5f316f2334473ca81875 Git commit 243512428014651a469ae7b94edbce81e2480e11 by Volker Hilsheimer on 18/07/2026 at 03:00.. QQuickToolTip: prepare for toolTipWakeUpDelay being std::chrono While QML cannot deal with std::chrono, our C++ APIs dealing with time should be chrono-first. QStyleHints::toolTipWakeUpDelay was ported to std::chrono, but we need to keep the QQuickToopTip API int-based, so convert explicitly. Amends f55a093c97b4e07e4578ddd2494d28ed9a118778 to address header review comments. Pick-to: 6.12 Task-number: QTBUG-146286 Change-Id: I4e967ea060fd7364a96a36803075a411b21a149d Reviewed-by: Fabian Kosmale <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/243512428014651a469ae7b94edbce81e2480e11 Git commit d4fcc5bd5e59f82767c16df9b9a55b30efe2687e by Dilek Akcay on 18/07/2026 at 10:27.. StyleKit: Implement SwitchDelegate Pick-to: 6.12 Change-Id: I3ce5974e40bbd118d95ac74f869d7b1204196238 Reviewed-by: Doris Verria <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/d4fcc5bd5e59f82767c16df9b9a55b30efe2687e Git commit ba4049ac9f880c708104b23be39ac4e449551d9c by Dilek Akcay on 18/07/2026 at 10:27.. StyleKit Example: Fix ScrollIndicator positioning in Plain style ScrollIndicator was positioned too far inside Menu and Popup because it had no explicit padding and therefore inherited control's padding values through fallback. These values were larger than intended for a ScrollIndicator. Set explicit padding values to position it correctly. Pick-to: 6.12 Change-Id: I513dfbbac9a81805614905cd56d1715b83ab99cc Reviewed-by: Doris Verria <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/ba4049ac9f880c708104b23be39ac4e449551d9c Git commit 11524c090191c60982951d6c5a943eb8cb3e81ee by Richard Moe Gustavsen on 18/07/2026 at 11:08.. StyleKit, ComboBox: set StopAtBounds on the popup ListView Being able to overshoot the ListView inside the combo box popup is unusual, and comes across as a glitch in practice for smaller menus, especially when using the mouse wheel for scrolling. This patch will disable being able to overshoot the popup menu. Pick-to: 6.12 Change-Id: I24c7c29d60192a77e19ff8f4878f5eb74f568db0 Reviewed-by: Doris Verria <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/11524c090191c60982951d6c5a943eb8cb3e81ee Git commit c6b7c7a0a3f5841231c8daf9bb074ba2a7249d9b by Richard Moe Gustavsen on 18/07/2026 at 11:08.. StyleKit, comboBox: add a note about how to style the popup It might not be obvious that the drop-down menu of a combo box is styled through popup + itemDelegate and not menu + menuItem. So add a note about this fact. Pick-to: 6.12 Change-Id: I99c19b4a49ed62e82df3949af10f2a5283adc0c9 Reviewed-by: Doris Verria <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/c6b7c7a0a3f5841231c8daf9bb074ba2a7249d9b Git commit 01256393294b084d4636cced98eb6bba8639a888 by Richard Moe Gustavsen on 18/07/2026 at 11:08.. StyleKit: improve DelegateStyle width/height documentation Amends 3103b9d6cc After removing implicitWidth and implicitHeight from the DelegateStyle API in favor of width and height, some places slipped through the cracks. This patch will correct the remaining places. Pick-to: 6.12 Change-Id: I3cd882072535addf5870be38dac68e4d2d5d6595 Reviewed-by: Doris Verria <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/01256393294b084d4636cced98eb6bba8639a888 Git commit f943d8e2ee647e335d1745174546594a5d03e2d3 by Richard Moe Gustavsen on 18/07/2026 at 11:08.. StyleKit: set the size of the indicator its foreground independently As it stood, the implicit size of the IndicatorDelegate would be the max of the indicator's own size and its foreground's size. But this is wrong. Consider: checkBox { indicator.width: 30 indicator.foreground.width: 40 } Here the indicator width is hard-coded to 30. But since indicator.foreground has a width of 40, the indicator would end up with a width of 40 as well. This is confusing, since if you hard-code the indicator to have a width of 30, you expect it to be 30 wide, not 40. Change this so that the sizes of the indicator and its foreground are controlled independently. This also means that the foreground is allowed to be bigger than its parent, and alignment and margins decide how it's then positioned on top, as expected. Since the default implicit size implementation of a DelegateContainer does exactly that, simply remove the implicitWidth/height overrides. Note: Normally it's better to set fillWidth and fillHeight on the foreground to make it fit inside the parent indicator. That way, the size set on the indicator will also dictate the size of the foreground. But the designer should not be limited to this approach. Pick-to: 6.12 Change-Id: I4cbc36e5a6723666873efe6a8d354e70590e9a44 Reviewed-by: Doris Verria <[email protected]> https://invent.kde.org/qt/qt/qtdeclarative/-/commit/f943d8e2ee647e335d1745174546594a5d03e2d3