[system/dolphin] src/kitemviews: KFileItemModel: drop a redundant icon lookup that blocked folder loading

Méven Car <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git commit 2c7e64c4de0d4a3a732b0759219ddd1b956fc87e by Méven Car, on behalf of Chinmoy Pradhan.
Committed on 23/07/2026 at 09:10.
Pushed by meven into branch 'master'.

KFileItemModel: drop a redundant icon lookup that blocked folder loading

M  +3    -7    src/kitemviews/kfileitemmodel.cpp

https://invent.kde.org/system/dolphin/-/commit/2c7e64c4de0d4a3a732b0759219ddd1b956fc87e

diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp
index 1ca74537d1..0dd9f58d81 100644
--- a/src/kitemviews/kfileitemmodel.cpp
+++ b/src/kitemviews/kfileitemmodel.cpp
@@ -25,7 +25,6 @@
 #include <QAccessible>
 #endif
 #include <QElapsedTimer>
-#include <QIcon>
 #include <QMimeData>
 #include <QMimeDatabase>
 #include <QRecursiveMutex>
@@ -2333,14 +2332,11 @@ QHash<QByteArray, QVariant> KFileItemModel::retrieveData(const KFileItem &item,
     }
 
     if (item.isMimeTypeKnown()) {
-        QString iconName = item.iconName();
-        if (!QIcon::hasThemeIcon(iconName)) {
-            QMimeType mimeType = QMimeDatabase().mimeTypeForName(item.mimetype());
-            iconName = mimeType.genericIconName();
+        const QString iconName = item.iconName();
+        if (!iconName.isEmpty()) {
+            data.insert(sharedValue("iconName"), iconName);
         }
 
-        data.insert(sharedValue("iconName"), iconName);
-
         if (m_requestRole[TypeRole]) {
             data.insert(sharedValue("type"), item.mimeComment());
         }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.