[qt/qt/qtimageformats]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qt/qtimageformats Pushed by mirror-service into branch '6.11'. Changed from c9e62455c3e5abd49d8088c2c2e9fc326fbbed49 to 00f7a206935d585d8e9bd2e9ddd3c99ac21ea7bf Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit d9ca15633cab13328feb52176dcb78bbe898e194 by Marc Mutz on 23/07/2026 at 21:46.. QTiffHandler: de-duplicate the compression field writing Every single format-specific branch wrote this the same way, so we can drag it before said format-specific branches, like e.g. orientation and color space fields already are. The order in which these fields are written is not significant. Tags in TIFF files are sorted by numerical value, anyway, cf. TIFFv6, p.16, Section "Sort Order": https://web.archive.org/web/20210108174645/https://www.adobe.io/content/dam/udp/en/open/standards/tiff/TIFF6.pdf (yes, spec only avilable via Wayback Machine; both wikipedia.org and loc.gov link to it that way; scary...) As a drive-by, inline the 'compression' variable into its now-only user. Amends the move of the TIFF plugin from qtbase into this module (f68a3dc48d8fb8c04fe49dd9e5d07d7cdd221ad1, 5.0). Manual conflict resolution for 6.11: - rebased to before conflicting change 5b1d401a523a229e0523e06a591ab3d447e84916. The analysis (all formats write the same value) remains correct. Pick-to: 6.8 Change-Id: I822a2d2698692c58d9f2ab71b1ebb14bc546923c Reviewed-by: Allan Sandfeld Jensen <[email protected]> (cherry picked from commit 44bd2b05cca9ad0b9db97875e9ca327b860161e3) Reviewed-by: Qt Cherry-pick Bot <[email protected]> (cherry picked from commit 29accac317f8f9409f5c7c3b1a259259d17cb2ff) Reviewed-by: Marc Mutz <[email protected]> https://invent.kde.org/qt/qt/qtimageformats/-/commit/d9ca15633cab13328feb52176dcb78bbe898e194 Git commit fac1e87e419100bec6d814b56110df4b3ca59033 by Qt Cherry-pick Bot (on behalf of Marc Mutz) on 23/07/2026 at 22:14.. QTiffHandler: fix Coverity warning about unchecked return values When TIFFIsTiled() returns true, then TIFFGetField(TILEWIDTH/LENGTH) oughtn't fail, but don't depend on internals of libtiff (the docs don't guarantee this), so check their return values, too. Found by Coverity complaining that two out of 16 TIFFGetField() calls didn't have their return values checked. Amends 30301436b59efe7ff25991cbbaa388f6f1b4d66e (5.9). Pick-to: 6.8 Coverity-Id: 178800 Change-Id: I8aa8e2080b47ea0597170a46ddc86699f438d001 Reviewed-by: Allan Sandfeld Jensen <[email protected]> (cherry picked from commit 0f53243accb9bc74cf66d9cc61d337d66a939de3) Reviewed-by: Qt Cherry-pick Bot <[email protected]> (cherry picked from commit fc36c8b7ae9c95ac86d6fdc084467b48889f8b15) https://invent.kde.org/qt/qt/qtimageformats/-/commit/fac1e87e419100bec6d814b56110df4b3ca59033 Git commit 00f7a206935d585d8e9bd2e9ddd3c99ac21ea7bf by Qt Cherry-pick Bot (on behalf of Marc Mutz) on 23/07/2026 at 22:48.. QTiffHandler: move some private methods to the Private class This is in preparation of an important read() robustness refactoring (dragging the error-prone manual d->close() out of the functional parts of read()). As a drive-by, drop the floatingPoint argument of rgb48fixup(), which would otherwise now shadow Private::floatingPoint(), and which the method can just as well read from *this. Pick-to: 6.8 Change-Id: I3d64ce4cf7e34c5b51674ca16c601e9a4c393d2b Reviewed-by: Allan Sandfeld Jensen <[email protected]> (cherry picked from commit e4a5ff139d440034b44c075a58ad69ac34bf4206) Reviewed-by: Qt Cherry-pick Bot <[email protected]> (cherry picked from commit 5e50cca2b9473d547b74e2ee0a16ade62d8a7487) https://invent.kde.org/qt/qt/qtimageformats/-/commit/00f7a206935d585d8e9bd2e9ddd3c99ac21ea7bf