[network/neochat] src: Remove the "Automatically hide/unhide the room information" setting
Joshua Goins <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit 53cd4698e4da244c50f708e7c4b5c71b1cc9b6e7 by Joshua Goins.
Committed on 25/07/2026 at 22:05.
Pushed by redstrate into branch 'master'.
Remove the "Automatically hide/unhide the room information" setting
This has dubious usefulness to people, and apparently doesn't even work
properly according to at least one bug. It seems to be one of those
things that was implemented in 2022 and not seen much love since, let's
remove it.
CCBUG: 495137
M +0 -4 src/app/neochatconfig.kcfg
M +0 -18 src/app/qml/Main.qml
M +1 -17 src/settings/NeoChatGeneralPage.qml
https://invent.kde.org/network/neochat/-/commit/53cd4698e4da244c50f708e7c4b5c71b1cc9b6e7
diff --git a/src/app/neochatconfig.kcfg b/src/app/neochatconfig.kcfg
index b23338963..a0541d84d 100644
--- a/src/app/neochatconfig.kcfg
+++ b/src/app/neochatconfig.kcfg
@@ -50,10 +50,6 @@
<entry name="PublicReadReceipts" type="Bool">
<default>true</default>
</entry>
- <entry name="AutoRoomInfoDrawer" type="Bool">
- <label>Automatic Hide/Unhide Room Information</label>
- <default>true</default>
- </entry>
<entry name="DeveloperTools" type="Bool">
<label>Enable developer tools</label>
<default>false</default>
diff --git a/src/app/qml/Main.qml b/src/app/qml/Main.qml
index f32da544b..e9787550a 100644
--- a/src/app/qml/Main.qml
+++ b/src/app/qml/Main.qml
@@ -153,10 +153,6 @@ Kirigami.ApplicationWindow {
}
contextDrawer: RoomDrawer {
- // This is a memory for all user initiated actions on the drawer, i.e. clicking the button
- // It is used to ensure that user choice is remembered when changing pages and expanding and contracting the window width
- property bool drawerUserState: NeoChatConfig.autoRoomInfoDrawer
-
room: RoomManager.currentRoom
connection: root.connection
userListModel: RoomManager.userListModel
@@ -176,22 +172,8 @@ Kirigami.ApplicationWindow {
// Default icon is fine, only need to override the tooltip text
handleOpenToolTip: i18nc("@action:button", "Close Room Information Drawer")
- // Connect to the onClicked function of the RoomDrawer handle button
- Connections {
- target: root.contextDrawer.handle.children[0]
- function onClicked() {
- root.contextDrawer.drawerUserState = root.contextDrawer.drawerOpen;
- }
- }
-
modal: (!root.wideScreen || !enabled)
onEnabledChanged: drawerOpen = enabled && !modal
- onModalChanged: {
- if (NeoChatConfig.autoRoomInfoDrawer) {
- drawerOpen = !modal && drawerUserState;
- dim = false;
- }
- }
enabled: RoomManager.hasOpenRoom && root.pageStack.layers.depth < 2 && root.pageStack.depth < 3 && (root.pageStack.visibleItems.length > 1 || root.pageStack.currentIndex > 0) && !Kirigami.Settings.isMobile && root.pageStack.wideMode
handleVisible: enabled
}
diff --git a/src/settings/NeoChatGeneralPage.qml b/src/settings/NeoChatGeneralPage.qml
index 600e81afc..df001e982 100644
--- a/src/settings/NeoChatGeneralPage.qml
+++ b/src/settings/NeoChatGeneralPage.qml
@@ -55,26 +55,10 @@ FormCard.FormCardPage {
FormCard.FormDelegateSeparator {
above: minimizeDelegate
- below: automaticallyDelegate
+ below: categorizeDelegate
visible: minimizeDelegate.visible
}
- FormCard.FormCheckDelegate {
- id: automaticallyDelegate
- text: i18n("Automatically hide/unhide the room information when resizing the window")
- checked: NeoChatConfig.autoRoomInfoDrawer
- enabled: !NeoChatConfig.isAutoRoomInfoDrawerImmutable
- visible: Qt.platform.os !== "android"
- onToggled: {
- NeoChatConfig.autoRoomInfoDrawer = checked;
- NeoChatConfig.save();
- }
- }
-
- FormCard.FormDelegateSeparator {
- above: automaticallyDelegate
- below: categorizeDelegate
- }
FormCard.FormCheckDelegate {
id: categorizeDelegate
text: i18n("Show all rooms in \"Home\" tab")