[qt/qt/qtremoteobjects]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qt/qtremoteobjects Pushed by mirror-service into branch 'dev'. Changed from fec168b71b3b7d4736d2825131d584d2bdb6e298 to f2331eb16d9bd565a8f72ca0e6ee06187899cfa1 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit 4c8f01c2740c97dc53f6baad9fb34ecb88051047 by Ivan Solovev on 27/07/2026 at 11:20.. Remove unused variables in qremoteobjectnode.cpp Found by Axivion static analysis. Commit e77c98352c584bac7b752dde21c93ff09f78b00d started deserializing the data directly into a ClassSlot instance, but didn't remove the now unused local variables. Do it now. The original commit was merged into 6.9, so picking only down to 6.11. Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV95 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV96 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV97 Task-number: QTBUG-144772 Pick-to: 6.12 6.11 Change-Id: I093605cc0bf83d59aba637a256bfb50156d4397a Reviewed-by: Tatiana Borisova <[email protected]> https://invent.kde.org/qt/qt/qtremoteobjects/-/commit/4c8f01c2740c97dc53f6baad9fb34ecb88051047 Git commit 5ae43a67a5a6ebc5e7fd33dea0a1870c8692ad8a by Ivan Solovev on 27/07/2026 at 11:20.. qremoteobjectsource.cpp: be more explicit on what we delete In the ranged-for loops over m_children, each 'it' variable is a QPointer. Calling delete on it is perfectly fine, because it goes via operator T*(). However, the follow-up change will take 'it' by const-ref instead of by-value, and then the code will be a bit confusing (i.e. calling delete on a const ref). To make it more readable, explicitly call data(), to signal that we're deleting the underlying data. Amends d9ee9fff1b9291395ba7ab75d7e46ddf4a9ff3a4. Pick-to: 6.12 6.11 6.8 Change-Id: I2a9f7d8eff55a7101d7b067a6454e3517b4cc013 Reviewed-by: Tatiana Borisova <[email protected]> https://invent.kde.org/qt/qt/qtremoteobjects/-/commit/5ae43a67a5a6ebc5e7fd33dea0a1870c8692ad8a Git commit fa8a8a18627c38b99a2fdaadfce72f3637e73ba3 by Ivan Solovev on 27/07/2026 at 11:20.. Fix Qt-RangeLoopReference warnings All cases use ranged-for loop to iterate over non-trivially-copyable data (QVariant, QByteArray, QPointer). In all cases it's better to take the values by const-ref, rather than do actual copies. Amends multiple patches, but all of them preceed Qt 6.8, so it's safe to pick down to that branch. Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV78 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV88 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV89 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV90 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV91 Task-number: QTBUG-144772 Pick-to: 6.12 6.11 6.8 Change-Id: I24dea8db3dc562dd819e6add1bd4094f0caf73db Reviewed-by: Tatiana Borisova <[email protected]> https://invent.kde.org/qt/qt/qtremoteobjects/-/commit/fa8a8a18627c38b99a2fdaadfce72f3637e73ba3 Git commit b9e9ccba9a7ec83fbcf95bfd07c1afde08a8ad09 by Ivan Solovev on 27/07/2026 at 11:20.. Fix Qt-RangeLoopDetach warnings: trivial cases To prevent detaching, wrap the containers into std::as_const(). If the container is an rvalue, it's impossible to use std::as_const(). In such cases introduce a local const variable. Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV248 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV249 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV250 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV255 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV256 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV257 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV291 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV328 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV329 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV330 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV331 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV332 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV334 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV335 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV336 Task-number: QTBUG-144772 Pick-to: 6.12 6.11 6.8 Change-Id: I87d1fd52aaa219c0c75671765d421531dca68ca3 Reviewed-by: Tatiana Borisova <[email protected]> https://invent.kde.org/qt/qt/qtremoteobjects/-/commit/b9e9ccba9a7ec83fbcf95bfd07c1afde08a8ad09 Git commit 8028972dc58e7ad776407c6136568125703cca4c by Ivan Solovev on 27/07/2026 at 11:20.. Fix Qt-RangeLoopDetach: iteration over QMap::keys() A loop that iterates a map over QMap::keys() and then accesses the elements via operator[] can be more efficiently replaced with QMap::asKeyValueRange(). Amends e8cadf8f88128758725ef7498ed7164751095832. QMap::asKeyValueRange() is available since Qt 6.4, so we can pick the change to all active branches. Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV333 Task-number: QTBUG-144772 Pick-to: 6.12 6.11 6.8 Change-Id: Idf19ceb35784cd062dc591264b03c9097c189744 Reviewed-by: Tatiana Borisova <[email protected]> https://invent.kde.org/qt/qt/qtremoteobjects/-/commit/8028972dc58e7ad776407c6136568125703cca4c Git commit b4d8c52362e498622b3627bd501b65103ae6ad5d by Ivan Solovev on 27/07/2026 at 11:20.. Fix Qt-RangeLoopDetach warning in structured bindings Several range-for loops are iterating over variables obtained via structured bindings. The warning was triggered because the variables are non-const. Could be fixed in a usual way by wrapping the usages in std::as_const(), but a better solution would be to initially declare them const. Amends e77c98352c584bac7b752dde21c93ff09f78b00d and c03d630e6d9631791d0668b64025bd82796a55ce. Both of them do not exist in 6.8, so picking only down to 6.11. Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV251 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV252 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV253 Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV254 Task-number: QTBUG-144772 Pick-to: 6.12 6.11 Change-Id: Ia0fb7da547798d3a05a5c928f423692dc7706d28 Reviewed-by: Tatiana Borisova <[email protected]> Reviewed-by: Dennis Oberst <[email protected]> https://invent.kde.org/qt/qt/qtremoteobjects/-/commit/b4d8c52362e498622b3627bd501b65103ae6ad5d Git commit f2331eb16d9bd565a8f72ca0e6ee06187899cfa1 by Ivan Solovev on 27/07/2026 at 11:20.. qremoteobjectnode.cpp: do not use auto when constructing QBA It deduces the return type to QStringBuilder instead of QByteArray. Originally pointed out by Axivion, which complains that it can cause a crash. The complaint is not valid since qtbase/af8f9a2a6e3dbc865470f8d7f09b533ccea4f353. However, it is still better to explicitly use QByteArray here. QStringBuilder does the concatenation every time the variable is used, instead of doing it once. In this case the variable is used twice, so using QStringBuilder is less efficient then immediately converting the result to QByteArray. Amends c03d630e6d9631791d0668b64025bd82796a55ce (picked to 6.9). Axivion-Id: qt_Add-ons_qtremoteobjects_dev_linux:SV100 Fixes: QTBUG-144772 Pick-to: 6.12 6.11 Change-Id: I9f807bce7bfa921b02dc07f49d86e303eb38f9b6 Reviewed-by: Marc Mutz <[email protected]> https://invent.kde.org/qt/qt/qtremoteobjects/-/commit/f2331eb16d9bd565a8f72ca0e6ee06187899cfa1