[qt/clang/llvm]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/clang/llvm Pushed by mirror-service into branch 'upstream/users/abhinavgaba/attach-maps-in-mappers-4'. Changed from b705dab0717b6ef63b486341a6ef688029ea688b to 123063fff8e6a887943bb4871975328d014f1c73 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit ece9735c44d13dc1c22f2b2957f1328a1a488351 by Abhinav Gaba on 27/07/2026 at 23:44.. [OpenMP][test] Add mapper ALWAYS-propagation tests with no target construct Companions to mapper_map_always_from.c that exercise ALWAYS propagation into a user-defined mapper's entries without entering any target region. The device copy is inspected directly via omp_get_mapped_ptr() and omp_target_memcpy(), so the check covers only the data-motion performed by `target enter data`. The Fortran variant is the first Fortran offload test that runs on the host (x86_64) target: it needs no device kernel, so it does not depend on a device runtime being available. Both tests currently CHECK the pre-propagation behavior (the transfer is suppressed for the already-mapped entry) and record the expected value in a FIXME. https://invent.kde.org/qt/clang/llvm/-/commit/ece9735c44d13dc1c22f2b2957f1328a1a488351 Git commit 021f7f4457a031b29030a55844bb530b77239c0a by Abhinav Gaba on 27/07/2026 at 23:45.. [OpenMP] Propagate ALWAYS/DELETE/CLOSE map-type modifiers to mapper entries When a map clause uses a user-defined mapper, the map-type-modifying bits (ALWAYS, DELETE, CLOSE) on the outer clause must apply to each map the mapper inserts (OpenMP 6.0:281:34). Propagate them in emitUserDefinedMapper by OR-ing the imported modifier bits into each pushed component, except ATTACH entries (ATTACH|ALWAYS is reserved for attach(always) and the other bits are meaningless for ATTACH). PRESENT is intentionally not propagated here yet (a TODO notes it is handled in a follow-on, since it requires distinguishing pointee entries from the struct's own storage). Update the offload always-propagation tests to their now-correct behavior: ALWAYS forces a member transfer that the ref count would otherwise suppress, so mapper_map_always_from.c reads s.y back as 111, and the enter-data variants (C and Fortran) see 111 in the device copy (all were 0 before this change). Since emitUserDefinedMapper is shared between clang and flang, the Fortran test covers the flang path as well. Co-Authored-By: Claude Opus 4.8 <[email protected]> https://invent.kde.org/qt/clang/llvm/-/commit/021f7f4457a031b29030a55844bb530b77239c0a Git commit 5f0e43b7a772963cb98d9916b298bfa0ec913f91 by Abhinav Gaba on 27/07/2026 at 23:46.. [OpenMP][Clang] Enable ATTACH-style maps for mappers. Track per-entry attach-ptr info (HasAttachPtr) through mapper codegen so that emitUserDefinedMapper does not add a new outer MEMBER_OF to pointee/combined entries (which occupy different storage than the struct) or to ATTACH entries. Clang and the MLIR translator populate the per-entry array in parallel with the other MapInfosTy arrays. Address review: - Rename MapSkipMemberOfArrayTy to MapHasAttachPtrArrayTy to match the HasAttachPtr field it backs. - Restructure the emitUserDefinedMapper comment into a bulleted (*)/(**)/(***) list keyed to the example entries. - Reword the Clang comments: HasAttachPtr marks pointee entries that have a base attach-ptr; a combined entry has a base attach-ptr if its constituents do; cross-reference emitUserDefinedMapper for the MEMBER_OF rationale. - Update the moved present-check tests to their now-correct behavior (the attach-style maps make the inbounds present checks pass and remove the "explicit extension" errors). Co-Authored-By: Claude Opus 4.8 <[email protected]> https://invent.kde.org/qt/clang/llvm/-/commit/5f0e43b7a772963cb98d9916b298bfa0ec913f91 Git commit 123063fff8e6a887943bb4871975328d014f1c73 by Abhinav Gaba on 27/07/2026 at 23:46.. [OpenMP] Propagate PRESENT to pointee entries in mapper codegen Extend map-type-modifier propagation in emitUserDefinedMapper to the PRESENT modifier, but only for entries that have an attach ptr (the pointee data, whose storage differs from the struct's own). A present modifier on the outer clause must require that pointee to be present on the device. This is gated on a new PropagatePresentToPointee argument, which Clang sets from CGM.getLangOpts().OpenMP >= 60. Before 6.0 the present modifier is treated as not applying to the pointee: the spec committee confirmed the divergence between the present motion modifier (to/from) and the present map-type modifier (map) was unintentional, to be fixed as an OpenMP 6.0 erratum. Only propagation is gated; present written directly in a mapper's own clause applies at all versions. A TODO notes PRESENT should also propagate to the struct's own members, which is blocked while pointer members use PTR_AND_OBJ. Update the present-check tests to their final 6.0-gated behavior. Co-Authored-By: Claude Opus 4.8 <[email protected]> https://invent.kde.org/qt/clang/llvm/-/commit/123063fff8e6a887943bb4871975328d014f1c73