[system/dolphin] src/kitemviews: Toggle group collapse only on left click

Kai Uwe Broulik <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git commit 953956710f5737aa696c120b17e82376ec185da3 by Kai Uwe Broulik.
Committed on 28/07/2026 at 05:58.
Pushed by meven into branch 'master'.

Toggle group collapse only on left click

Otherwise right clicking to bring up the context menu may
inadvertently collapse a group.

M  +12   -10   src/kitemviews/kitemlistview.cpp

https://invent.kde.org/system/dolphin/-/commit/953956710f5737aa696c120b17e82376ec185da3

diff --git a/src/kitemviews/kitemlistview.cpp b/src/kitemviews/kitemlistview.cpp
index 34b987cf88..2951a2b384 100644
--- a/src/kitemviews/kitemlistview.cpp
+++ b/src/kitemviews/kitemlistview.cpp
@@ -1081,17 +1081,19 @@ bool KItemListView::event(QEvent *event)
 {
     if (m_grouped && event->type() == QEvent::GraphicsSceneMousePress) {
         auto *mouseEvent = static_cast<QGraphicsSceneMouseEvent *>(event);
-        const QPointF pos = transform().map(mouseEvent->pos());
+        if (mouseEvent->button() == Qt::LeftButton) {
+            const QPointF pos = transform().map(mouseEvent->pos());
 
-        QHashIterator<int, KItemListGroupHeader *> it(m_visibleGroups);
-        while (it.hasNext()) {
-            it.next();
-            KItemListGroupHeader *header = it.value();
-            const QPointF mappedToGroup = header->mapFromItem(this, pos);
-            if (header->contains(mappedToGroup)) {
-                toggleGroupCollapse(header->data());
-                event->accept();
-                return true;
+            QHashIterator<int, KItemListGroupHeader *> it(m_visibleGroups);
+            while (it.hasNext()) {
+                it.next();
+                KItemListGroupHeader *header = it.value();
+                const QPointF mappedToGroup = header->mapFromItem(this, pos);
+                if (header->contains(mappedToGroup)) {
+                    toggleGroupCollapse(header->data());
+                    event->accept();
+                    return true;
+                }
             }
         }
     }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.