[pim/messagelib] messagelist/src/core: Const'ify more variables

Git commit d4be517e0ee8a0c7b4bfebfae1e9c650fe0b0b51 by Laurent Montel.
Committed on 30/07/2026 at 05:09.
Pushed by mlaurent into branch 'master'.

Const'ify more variables

M  +1    -3    messagelist/src/core/aggregation.cpp
M  +3    -3    messagelist/src/core/filter.cpp
M  +12   -11   messagelist/src/core/filtersavedmanager.cpp
M  +1    -1    messagelist/src/core/widgets/searchlinestatus.cpp

https://invent.kde.org/pim/messagelib/-/commit/d4be517e0ee8a0c7b4bfebfae1e9c650fe0b0b51

diff --git a/messagelist/src/core/aggregation.cpp b/messagelist/src/core/aggregation.cpp
index 067e9ec47..3a6e6b8b1 100644
--- a/messagelist/src/core/aggregation.cpp
+++ b/messagelist/src/core/aggregation.cpp
@@ -40,9 +40,7 @@ Aggregation::Grouping Aggregation::grouping() const
     return mGrouping;
 }
 
-Aggregation::Aggregation(const Aggregation &opt)
-
-    = default;
+Aggregation::Aggregation(const Aggregation &opt) = default;
 
 Aggregation::Aggregation()
     : mGrouping(NoGrouping)
diff --git a/messagelist/src/core/filter.cpp b/messagelist/src/core/filter.cpp
index cc5b8f0cc..1a7c414ad 100644
--- a/messagelist/src/core/filter.cpp
+++ b/messagelist/src/core/filter.cpp
@@ -341,10 +341,10 @@ void Filter::save(const KSharedConfig::Ptr &config, const QString &filtername, c
 
 Filter *Filter::load(const KSharedConfig::Ptr &config, int filternumber)
 {
-    KConfigGroup grp(config, u"General"_s);
-    int numberFilter = grp.readEntry("NumberFilter").toInt();
+    const KConfigGroup grp(config, u"General"_s);
+    const int numberFilter = grp.readEntry("NumberFilter").toInt();
     if (filternumber < numberFilter) {
-        KConfigGroup newGroup(config, u"Filter_%1"_s.arg(filternumber));
+        const KConfigGroup newGroup(config, u"Filter_%1"_s.arg(filternumber));
         return loadFromConfigGroup(newGroup);
     }
     return nullptr;
diff --git a/messagelist/src/core/filtersavedmanager.cpp b/messagelist/src/core/filtersavedmanager.cpp
index bcd1e9edb..91ac39616 100644
--- a/messagelist/src/core/filtersavedmanager.cpp
+++ b/messagelist/src/core/filtersavedmanager.cpp
@@ -29,11 +29,11 @@ FilterSavedManager *FilterSavedManager::self()
 QStringList FilterSavedManager::existingFilterNames() const
 {
     QStringList lst;
-    KConfigGroup grp(KSharedConfig::openConfig(), u"General"_s);
+    const KConfigGroup grp(KSharedConfig::openConfig(), u"General"_s);
     const int numberFilter = grp.readEntry("NumberFilter").toInt();
     lst.reserve(numberFilter);
     for (int i = 0; i < numberFilter; ++i) {
-        KConfigGroup newGroup(KSharedConfig::openConfig(), u"Filter_%1"_s.arg(i));
+        const KConfigGroup newGroup(KSharedConfig::openConfig(), u"Filter_%1"_s.arg(i));
         lst << newGroup.readEntry(u"name"_s);
     }
     return lst;
@@ -46,10 +46,10 @@ void FilterSavedManager::saveFilter(MessageList::Core::Filter *filter, const QSt
 
 void FilterSavedManager::loadMenu(QMenu *menu)
 {
-    KConfigGroup grp(KSharedConfig::openConfig(), u"General"_s);
+    const KConfigGroup grp(KSharedConfig::openConfig(), u"General"_s);
     const int numberFilter = grp.readEntry("NumberFilter").toInt();
     for (int i = 0; i < numberFilter; ++i) {
-        KConfigGroup newGroup(KSharedConfig::openConfig(), u"Filter_%1"_s.arg(i));
+        const KConfigGroup newGroup(KSharedConfig::openConfig(), u"Filter_%1"_s.arg(i));
         const QString iconName = newGroup.readEntry(u"iconName"_s);
         auto act = menu->addAction(QIcon::fromTheme(iconName), newGroup.readEntry(u"name"_s));
         const QString identifier = newGroup.readEntry(u"identifier"_s);
@@ -61,17 +61,18 @@ void FilterSavedManager::loadMenu(QMenu *menu)
 
 QList<FilterSavedManager::FilterInfo> FilterSavedManager::filterInfos() const
 {
-    KConfigGroup grp(KSharedConfig::openConfig(), u"General"_s);
+    const KConfigGroup grp(KSharedConfig::openConfig(), u"General"_s);
     const int numberFilter = grp.readEntry("NumberFilter").toInt();
     QList<FilterSavedManager::FilterInfo> lst;
     lst.reserve(numberFilter);
     for (int i = 0; i < numberFilter; ++i) {
-        KConfigGroup newGroup(KSharedConfig::openConfig(), u"Filter_%1"_s.arg(i));
+        const KConfigGroup newGroup(KSharedConfig::openConfig(), u"Filter_%1"_s.arg(i));
 
-        FilterSavedManager::FilterInfo info;
-        info.filterName = newGroup.readEntry(u"name"_s);
-        info.identifier = newGroup.readEntry(u"identifier"_s);
-        info.iconName = newGroup.readEntry(u"iconName"_s);
+        const FilterSavedManager::FilterInfo info{
+            .filterName = newGroup.readEntry(u"name"_s),
+            .identifier = newGroup.readEntry(u"identifier"_s),
+            .iconName = newGroup.readEntry(u"iconName"_s),
+        };
         lst << info;
     }
     return lst;
@@ -81,7 +82,7 @@ Filter *FilterSavedManager::loadFilter(const QString &identifier)
 {
     const QStringList list = KSharedConfig::openConfig()->groupList().filter(QRegularExpression(u"Filter_\\d+"_s));
     for (const QString &group : list) {
-        KConfigGroup newGroup(KSharedConfig::openConfig(), group);
+        const KConfigGroup newGroup(KSharedConfig::openConfig(), group);
         if (newGroup.readEntry("identifier") == identifier) {
             Filter *f = Filter::loadFromConfigGroup(newGroup);
             return f;
diff --git a/messagelist/src/core/widgets/searchlinestatus.cpp b/messagelist/src/core/widgets/searchlinestatus.cpp
index a2a060735..eba28202c 100644
--- a/messagelist/src/core/widgets/searchlinestatus.cpp
+++ b/messagelist/src/core/widgets/searchlinestatus.cpp
@@ -166,7 +166,7 @@ void SearchLineStatus::updateFilterLineEditBackgroundColor()
 {
     if (mColorName.isEmpty()) {
         const KColorScheme::BackgroundRole bgColorScheme(KColorScheme::PositiveBackground);
-        KStatefulBrush bgBrush(KColorScheme::View, bgColorScheme);
+        const KStatefulBrush bgBrush(KColorScheme::View, bgColorScheme);
         mColorName = bgBrush.brush(palette()).color().name();
     }
     setStyleSheet(mHasFilter ? u"QLineEdit{ background-color:%1 }"_s.arg(mColorName) : QString());