[office/tellico] src/models: Refresh all model columns when data changes

Robby Stephenson <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git commit 4a13183347022fa0b9efd8d526e97a4f40b561b9 by Robby Stephenson.
Committed on 01/08/2026 at 00:48.
Pushed by rstephenson into branch 'master'.

Refresh all model columns when data changes

M  +12   -9    src/models/entrymodel.cpp

https://invent.kde.org/office/tellico/-/commit/4a13183347022fa0b9efd8d526e97a4f40b561b9

diff --git a/src/models/entrymodel.cpp b/src/models/entrymodel.cpp
index 9a41829d8..b28486cdd 100644
--- a/src/models/entrymodel.cpp
+++ b/src/models/entrymodel.cpp
@@ -279,9 +279,9 @@ void EntryModel::clearSaveState() {
       // If the hash is modified while a QHashIterator is active, the QHashIterator
       // will continue iterating over the original hash, ignoring the modified copy.
       m_saveStates.remove(i.key());
-      QModelIndex idx1 = createIndex(i.key(), 0);
-      QModelIndex idx2 = createIndex(i.key(), m_fields.count() - 1);
-      Q_EMIT dataChanged(idx1, idx2, QVector<int>() << SaveStateRole);
+      Q_EMIT dataChanged(index(i.key(), 0),
+                         index(i.key(), m_fields.count()-1),
+                         {SaveStateRole});
     }
   }
 }
@@ -302,9 +302,10 @@ void EntryModel::addEntries(const Tellico::Data::EntryList& entries_) {
 
 void EntryModel::modifyEntries(const Tellico::Data::EntryList& entries_) {
   foreach(Data::EntryPtr entry, entries_) {
-    QModelIndex index = indexFromEntry(entry);
-    if(index.isValid()) {
-      Q_EMIT dataChanged(index, index);
+    const int idx = m_entries.indexOf(entry);
+    if(idx >= 0 && !m_fields.isEmpty()) {
+      Q_EMIT dataChanged(index(idx, 0),
+                         index(idx, m_fields.count()-1));
     }
   }
 }
@@ -439,9 +440,11 @@ void EntryModel::refreshImage(const QString& id_) {
   // remove from request list _before_ emitting dataChanged in case the cache drops the image
   m_requestedImages.remove(id_);
   for(const auto& entry : std::as_const(entries)) {
-    QModelIndex index = indexFromEntry(entry);
-    if(index.isValid()) {
-      Q_EMIT dataChanged(index, index, {Qt::DecorationRole, PrimaryImageRole});
+    const int idx = m_entries.indexOf(entry);
+    if(idx >= 0 && !m_fields.isEmpty()) {
+      Q_EMIT dataChanged(index(idx, 0),
+                         index(idx, m_fields.count()-1),
+                         {Qt::DecorationRole, PrimaryImageRole});
     }
   }
 }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.